This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
Cleanup of generator.js and moves out Babel serialization logic #2306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hermanventer
approved these changes
Jul 23, 2018
src/serializer/Referentializer.js
Outdated
| @@ -14,7 +14,7 @@ import type { SerializerOptions } from "../options.js"; | |||
| import * as t from "@babel/types"; | |||
| import generate from "@babel/generator"; | |||
| import type { BabelNodeStatement, BabelNodeExpression, BabelNodeIdentifier } from "@babel/types"; | |||
| import { NameGenerator } from "../utils/generator.js"; | |||
| import { NameGenerator } from "../utils/PreludeGenerator"; | |||
There was a problem hiding this comment.
Why not put NameGenerator in its own file? Importing it from generator.js seems plausible, but importing it from PreludeGenerator.js just seems weird.
There was a problem hiding this comment.
@trueadm is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes: none
This cleans up generator.js in the following ways:
This is of many PRs to help clean up the serialization/generator logic.