Skip to content
This repository has been archived by the owner on Sep 1, 2024. It is now read-only.

Remove unused code from production build #16

Closed
aweary opened this issue Apr 10, 2017 · 3 comments
Closed

Remove unused code from production build #16

aweary opened this issue Apr 10, 2017 · 3 comments
Assignees

Comments

@aweary
Copy link
Contributor

aweary commented Apr 10, 2017

See facebook/react#9398

Can we remove junk code from PropTypes prod build? It doesn't use bundle-collapser so it ships all those method names (e.g. “fbjs/lib/invariant”). This is fixable if you add “-p bundle-collapser/plugin” to browserify call. Additionally, there seems to be some junk invariant() code which is easy to fix if we just turn this into an inlined error. https://unpkg.com/prop-types@15.5.6/prop-types.min.js

@gaearon
Copy link
Contributor

gaearon commented Apr 11, 2017

Want to help? @aweary

@aweary aweary self-assigned this Apr 11, 2017
@aweary
Copy link
Contributor Author

aweary commented Apr 11, 2017

@gaearon happy to!

@aweary
Copy link
Contributor Author

aweary commented Apr 11, 2017

Resolved by #20

@aweary aweary closed this as completed Apr 11, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants