New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: support multiple country holidays #909
Comments
We had a lot of discussion about this when we were adding the country holidays feature. The big complication is with holidays that exist / overlap for both countries. Here are some examples of where things get weird:
Now maybe reasonable things will happen even if these identical holidays are not merged, but I think that'd need some extensive testing. Handling these in the "right" way (don't merge Thanksgivings, do merge New Years and Año nuevo) will be very hard to do without making a table of equivalent holidays. I'll leave this open as an enhancement to look into more in the future, but that's why there isn't the option to automatically stack country holidays. In the meantime, you can do this manually and make your own decision for which holiday should be merged or not. Here is how you get a holiday dataframe with country holidays:
You could then do the same thing for US, and then stack them after handling equivalent holidays as you'd like. Pass that dataframe in to |
@bletham this SO thread may be useful as it considers one of the examples on how to handle the holidays. |
Hello, Is France holidays available in the make_holidays_df? |
Most holidays comes from the |
Thanks, I'll check it out.
…On Fri, 4 Dec 2020 at 5:28 AM, Brendan Rocks ***@***.***> wrote:
Bit off topic, but @saccpp <https://github.com/saccpp>, "FR" fails due to
the holidays package, but the data's there.
Until this PR0 <https://github.com/dr-prodigy/python-holidays/pull/372>
lands to correct it, you can use "FRA" instead of "FR".
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#909 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOTFNTSBLIAS6A77INNHPQ3STAQ3TANCNFSM4HCN5QXA>
.
|
Hello,
This is because in some county like China Japan , people also would enjoy some foreign holidays .
For example , chocolate sales would grow on Valentine's Day .
Cake and apple(yes apple) sales would have large increase on Christmas Eve .
Current behaviour
Add a flag to determine whether appending or changing would be much better .
The text was updated successfully, but these errors were encountered: