Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pakage rename #1844

Merged
merged 4 commits into from
Mar 21, 2021
Merged

Pakage rename #1844

merged 4 commits into from
Mar 21, 2021

Conversation

bletham
Copy link
Contributor

@bletham bletham commented Mar 15, 2021

Rename fbprophet to prophet.

Make fbprophet a shim package that just imports prophet. Any code currently importing from fbprophet will continue to work, but will get a warning message that they should update to use the prophet name.

Update all of the notebooks to use the new package name.

I'll wait until after it is pushed to pypi to update the markdown documentation and references in the website.

Testing

Check that all references are changed:

grep -R fbprophet *

Check new prophet package works:

Uninstall prophet and fbprophet:

pip uninstall fbprophet
pip uninstall prophet

Make sure they're gone:

import fbprophet  # ModuleNotFoundError
import prophet  # ModuleNotFoundError

Install prophet and check that it works:

cd python
python setup.py install
cd prophet/tests
python -m unittest

Check the shim works:

cd ../../../python_shim
python setup.py install
cd fbprophet/tests
python -m unittest

Final check by running all notebooks with updated package name

All successful

Copy link
Contributor

@seanjtaylor seanjtaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested. Both shim and the new package work fine and pass all tests.

@bletham bletham merged commit 6d81543 into master Mar 21, 2021
@tcuongd tcuongd deleted the pakage_rename branch June 5, 2022 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants