Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to cmdstan 2.31.0 and build in temporary directory for Windows #2428

Merged
merged 8 commits into from May 28, 2023

Conversation

WardBrian
Copy link
Collaborator

This is a potential solution to #2402, at least on Windows. I believe the failures there are due to source installations ending up in places with very long path names, and that causing internal failures in g++.

@WardBrian
Copy link
Collaborator Author

@tcuongd at this point the only errors appear to also be errors on the main branch. I will try to test this on Windows locally to make sure it works even if the path to the source is very long.

@WardBrian
Copy link
Collaborator Author

Tested this on a local windows machine and confirmed installation succeeds even when in a very long/deeply nested path

Copy link
Collaborator

@tcuongd tcuongd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for digging into this!! The additional copy-paste logic is a little annoying but not sure if I have a cleaner solution right now, so happy to merge as is.

Separate to the windows issue, upgrading to 2.31.0 should also help resolve the issues people are having on M1s (tested the install and import + fit on my M1 machine and it worked fine):

So overall this will be a huge win!

@tcuongd tcuongd merged commit 9dd5c8c into facebook:main May 28, 2023
5 checks passed
@tcuongd tcuongd changed the title Build CmdStan and Stan Model in temporary directory Upgrade to cmdstan 2.31.0 and build in temporary directory for Windows May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants