issue-31-34 patch holiday forecast comp #39
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions. |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Awesome, thanks @rschoenbeck! |
issue-31-34 patch holiday forecast comp
Patches reported issues with column indexing via holiday.comps (i.e. for "x must be numeric" issue, #31) and requirement for 2+ unique holiday values (issue #34) for holiday forecasting component plot.