Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply non-duplicated colnames *before* coercing to a tbl_df #739

Merged
merged 1 commit into from Nov 21, 2018

Conversation

@jennybc
Copy link
Contributor

commented Nov 14, 2018

I'm helping @krlmlr to assess the potential impact of changes in dev tibble. I selected this package as one of the experiments, because it's one of the revdeps with considerable download activity.

prophet depends on tibble via dplyr.

tibble is getting stricter about tibbles with unnamed columns or duplicate column names. There are, of course, ways to explicitly allow that or request name repair, but that code would depend on a specific version of tibble.

This PR makes prophet work with the current CRAN version of tibble (v1.4.2) and with the coming release.

Apply colnames *before* coercing to a tbl_df
`dplyr::as_data_frame()` is really `tibble::as_tibble()`. An upcoming
release of tibble will be stricter about column names and, by default,
you can't have duplicate column names. This change allows prophet to
work with current CRAN tibble (v1.4.2) and the coming release.

cc @krlmlr
@facebook-github-bot

This comment has been minimized.

Copy link
Contributor

commented Nov 14, 2018

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@jennybc

This comment has been minimized.

Copy link
Contributor Author

commented Nov 14, 2018

CLA now signed

@facebook-github-bot

This comment has been minimized.

Copy link
Contributor

commented Nov 14, 2018

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@bletham bletham merged commit ebf7b3d into facebook:master Nov 21, 2018

@bletham

This comment has been minimized.

Copy link
Contributor

commented Nov 21, 2018

Thanks a bunch for the fix! We're planning to push this to CRAN at the end of next week.

@jennybc

This comment has been minimized.

Copy link
Contributor Author

commented Nov 21, 2018

Great to hear! A tibble 2.0.0 pre-announcement is imminent, with CRAN submission planned before the end of year.

christianoswald added a commit to christianoswald/prophet that referenced this pull request Nov 30, 2018

Merge pull request #1 from facebook/master
Apply colnames *before* coercing to a tbl_df (facebook#739)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.