Apply non-duplicated colnames *before* coercing to a tbl_df #739
Conversation
`dplyr::as_data_frame()` is really `tibble::as_tibble()`. An upcoming release of tibble will be stricter about column names and, by default, you can't have duplicate column names. This change allows prophet to work with current CRAN tibble (v1.4.2) and the coming release. cc @krlmlr
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
CLA now signed |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Thanks a bunch for the fix! We're planning to push this to CRAN at the end of next week. |
|
Great to hear! A tibble 2.0.0 pre-announcement is imminent, with CRAN submission planned before the end of year. |
I'm helping @krlmlr to assess the potential impact of changes in dev tibble. I selected this package as one of the experiments, because it's one of the revdeps with considerable download activity.
prophet depends on tibble via dplyr.
tibble is getting stricter about tibbles with unnamed columns or duplicate column names. There are, of course, ways to explicitly allow that or request name repair, but that code would depend on a specific version of tibble.
This PR makes prophet work with the current CRAN version of tibble (v1.4.2) and with the coming release.