Switch uses of __attribute__((__constructor__)) to dynamic initializers #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because the attribute isn't portable, and the dynamic initializers do the same thing.
|
Looks like a fun SIOF nightmare waiting to happen. Consider using folly::Singleton instead with eager initialization? |
|
As a note, |
|
There is no set initialization order between files before main. This can easily cause bugs, especially in larger projects. Better to have these values be done using some kind of singleton, either Meyers singleton (static local variable) or folly::Singleton. That will establish proper dependency ordering, and prevent this kind of bug. |
|
@Orvid, are you planning to address @yfeldblum's comment? |
|
Yep, but I'll bring it up as an internal diff when I do that. |
ghost
pushed a commit
that referenced
this pull request
Mar 25, 2016
Summary:Because MSVC doesn't support it. This is the new form of [Proxygen PR #66](#66). This currently only changes one of them, as I'm looking for feedback to make sure this is what was wanted. Reviewed By: afrind Differential Revision: D2946935 fb-gh-sync-id: 8e98b28628851c58592d046bcfd954a9c579a9cc fbshipit-source-id: 8e98b28628851c58592d046bcfd954a9c579a9cc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the attribute isn't portable, and the dynamic initializers do the same thing.