Skip to content

Commit

Permalink
Fix dependencies require and level-set (#766)
Browse files Browse the repository at this point in the history
Summary:
**Pre-submission checklist**
- [x] I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running `pip install -r requirements-dev.txt && pre-commit install`
- [x] `pre-commit run`

This PR fixed #765 .
#765 caused by 2 reasons.
1. We missed to install some dependencies.This is easy to find and fix, just as commit `Complete the dependencies required for pyre`.
2. The second reason is a hidden issue.If you installed `typing_extensions` and `typing_inspect`, and have a look for the `site-packages` directory, you could see like this:
![image](https://github.com/facebook/pyre-check/assets/120731947/495bdf6e-542c-4eca-b136-781b0a5863fb)
Obviously, they are `top_level_modules`.
But, we didn't declare them as `top_level_modules` explicitly, so Pyre think it isn't exist.

Pull Request resolved: #766

Test Plan:
[Before this PR](https://github.com/facebook/pyre-check/actions/runs/5686494990/job/15413364228#step:5:13), step `Run Pyre` actually failed with error message `Invalid configuration: Invalid path async_generator: does not exist.`

[After this PR](https://github.com/facebook/pyre-check/actions/runs/5689688725/job/15421658568?pr=766#step:5), step `Run Pyre` was sucessfull.

And you can see, this PR's CI were all successful.

Reviewed By: grievejia

Differential Revision: D47970095

Pulled By: connernilsen

fbshipit-source-id: a5e75e17196118409c79318d8eca9b30b51b5ed9
  • Loading branch information
WangGithubUser authored and facebook-github-bot committed Aug 2, 2023
1 parent 3884a88 commit 91e7256
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 8 deletions.
12 changes: 4 additions & 8 deletions .pyre_configuration
Expand Up @@ -11,9 +11,6 @@
"pyre_extensions/safe_json.py"
],
"search_path": [
{
"site-package": "async_generator"
},
{
"site-package": "click"
},
Expand Down Expand Up @@ -41,17 +38,16 @@
{
"site-package": "psutil"
},
{
"site-package": "pywatchman"
},
{
"site-package": "testslide"
},
{
"site-package": "typing_extensions"
"site-package": "typing_extensions",
"is_toplevel_module": true
},
{
"site-package": "typing_inspect"
"site-package": "typing_inspect",
"is_toplevel_module": true
}
],
"source_directories": [
Expand Down
1 change: 1 addition & 0 deletions requirements.txt
Expand Up @@ -7,3 +7,4 @@ pyre-extensions>=0.0.29
tabulate
testslide>=2.7.0
typing_extensions
typing_inspect

0 comments on commit 91e7256

Please sign in to comment.