Remove redundant pip install and add install for sapp #446
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #444 pointed out that SAPP is missing from the venv when doing the tutorial. This is because we removed
pyre-check
s dependency onfb-sapp
, so that users of Pyre wouldn't have to bring in a whole web server when all they wanted was a type checker. This change updates ourDockerfile
andREADME.md
to now explicitly installfb-sapp
.Additionally, we've fixed the dependencies on the
fb-sapp
package, and we no longer need to explicitly install dependencies likeflask
orclick
. For that reason, I've also removed the now redundant extrapip install
lines.Test Plan:
Removed my old venv:
Set up a new one with just
pyre-check
andfb-sapp
:Ran exercise 4, which requires both:
Was able to interactively explore models in SAPP