Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant pip install and add install for sapp #446

Closed

Conversation

gbleaney
Copy link
Contributor

@gbleaney gbleaney commented Jul 7, 2021

Issue #444 pointed out that SAPP is missing from the venv when doing the tutorial. This is because we removed pyre-checks dependency on fb-sapp, so that users of Pyre wouldn't have to bring in a whole web server when all they wanted was a type checker. This change updates our Dockerfile and README.md to now explicitly install fb-sapp.

Additionally, we've fixed the dependencies on the fb-sapp package, and we no longer need to explicitly install dependencies like flask or click. For that reason, I've also removed the now redundant extra pip install lines.

Test Plan:
Removed my old venv:

rm -rf tutorial/

Set up a new one with just pyre-check and fb-sapp:

pip3 install pyre-check fb-sapp

Ran exercise 4, which requires both:

pyre analyze --no-verify --save-results-to .
sapp analyze taint-output.json
sapp explore

Was able to interactively explore models in SAPP

@facebook-github-bot
Copy link
Contributor

@gbleaney has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Contributor

@abishekvashok abishekvashok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@facebook-github-bot
Copy link
Contributor

@gbleaney merged this pull request in 40cf5b0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants