Fix scroll to text node (#413)

* Fix scroll to text node * Address feedback
facebook · Aug 19, 2016 · 59508f6 · 59508f6
1 parent 776a0ae
commit 59508f6
Showing 1 changed file with 12 additions and 4 deletions.
diff --git a/agent/Agent.js b/agent/Agent.js
@@ -206,10 +206,18 @@ class Agent extends EventEmitter {
       console.warn('unable to get the node for scrolling');
       return;
     }
-    if (node.scrollIntoViewIfNeeded) {
-      node.scrollIntoViewIfNeeded();
-    } else {
-      node.scrollIntoView();
+    var element = node.nodeType === Node.ELEMENT_NODE ?
+      node :
+      node.parentElement;
+    if (!element) {
+      console.warn('unable to get the element for scrolling');
+      return;
+    }
+
+    if (typeof element.scrollIntoViewIfNeeded === 'function') {
+      element.scrollIntoViewIfNeeded();
+    } else if (typeof element.scrollIntoView === 'function') {
+      element.scrollIntoView();
     }
     this.highlight(id);
   }