This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
fix(getData): fix Stateless Functional Component source code doesn't … #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…show up correctly
|
|
|
I don't think this is the right fix. You are mutating the instance which we should avoid. |
nuoyz
force-pushed
the
fixbug-issue384
branch
from
987bcae
to
fe4094c
Compare
gaearon
suggested changes
Mar 9, 2017
| @@ -42,7 +42,7 @@ var config: Props = { | |||
| // the constructor. Otherwise, inspect the render function. | |||
| var code = `Object.getOwnPropertyDescriptor(window.${vbl}.__proto__.__proto__, 'isMounted') && | |||
| Object.getOwnPropertyDescriptor(window.${vbl}.__proto__.__proto__, 'isMounted').value ? | |||
| inspect(window.${vbl}.render) : inspect(window.${vbl}.constructor)`; | |||
| inspect(window.${vbl}.render) : inspect(window.${vbl}._reactInternalInstance._currentElement.type)`; | |||
There was a problem hiding this comment.
This is a bit gross because we're looking at internals but I don't really have a better alternative. Let's just fix this to work in Fiber: inspect(typeof window.${vbl}._reactInternalInstance.tag === 'number' ? window.${vbl}._reactInternalInstance.type : window.${vbl}._reactInternalInstance._currentElement.type)
|
Closing as review comments have not been addressed. Thanks for the PR though! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix Stateless Functional Component source code doesn't show up correctly