Algolia DocSearch dropdown is not shown when viewing versioned docs

[ravirajn22]

Is this a bug report?

Yes

Have you read the Contributing Guidelines?

yes

Environment

Environment:
OS: macOS Sierra 10.12.6
Node: 6.11.0
Yarn: 1.3.2
npm: 5.4.2
Watchman: 4.7.0
Xcode: Xcode 8.3.3 Build version 8E3004b
Android Studio: 2.3 AI-162.4069837
Chrome - 63.0.3239.84
Firefox - 57.0

Packages: (wanted => installed)
react-native: 0.48.1 => 0.48.1
react: 16.0.0-alpha.12 => 16.0.0-alpha.12

Target Platform: iOS (10.3)

Steps to Reproduce

(Write your steps here:)

1. Open Website https://facebook.github.io/react-native/
2. Search for Switch component using the search bar
3. Modal drop down appears with appropriate search results
4. Select Switch component
5. Inside Switch component docs, search for Button component.
6. Nothing happens.

But,
7. Go back again to home page i.e https://facebook.github.io/react-native/
8. Search for Button, it shows all search results again.

Expected Behavior

When you search for Button component inside Switch Component docs, a Modal dropdown must appear with all the search results

(Write what you thought would happen.)

Actual Behavior

Nothing happens! the search bar does nothing.

(Write what happened. Add screenshots!)

Reproducible Demo

(Paste the link to an example project and exact instructions to reproduce the issue.)

[hramos]

Looks like the dropdown is only triggered when viewing the latest version's docs. After navigating to 'next' or to a previous release, the drop down is not shown. Looks like anything that changes the base URL of the docs will cause this to happen.

[ravirajn22]

Please fix it soon, kind of tough to navigate and find features without search option.

[hramos]

You'll probably want to take a look at the pages/ files in this repo. It may also be a bug with Docusaurus itself. Ping me here if you open a PR on either repo and I can take a look.

[hramos]

@s-pace has some insight about this, copying over from another issue:

👋 guys,

React Native features DocSearch.

@MoOx the issue isn't coming from our side but from the DocSearch snippet

🏓 @hramos (@vjeux)

It look like the master pages aren't using the right tag (The latest version is hardcoded instead of master).

I have made a quick fix in order to don't stop the search in production but please update your tag from your DocSearch snippet. I can't do a PR on the gh-pages according to your Contributing Guide.

It is not the first time this issue happen.

Feel free to ask us for any other point, we would be happy to help.

I think this may need to be fixed upstream in Docusaurus (see my comment here s-pace/react-native@4bf072a).

[hramos]

facebook/docusaurus#418

[methodbox]

Are you guys aware this is still broken? The docs are effectively unusable without search.

This seems to break every couple of weeks.

Edit: you might have some duplicate issues here: #998 and here: #985

[s-pace]

The crawl is pretty long and was stopped. Can you check now @methodbox ? Should be fine

[methodbox]

The crawl is pretty long and was stopped. Can you check now @methodbox ? Should be fine

Not sure what you mean by, "the crawl is pretty long...". Can you clarify?

It seems to be working now. However, your test image shows the actual home page; note that this was particularly and issue after searching and/or on the actual docs page. Both seem to work okay now, though.

Please also understand it wasn't just the quick search drop-down - hitting Enter did nothing; it literally would not search.

[s-pace]

The daily crawl was too long so it was not correctly done. Should be fixed now :)

[Simek]

It also looks like a fixed issue for me. @methodbox Feel free to reopen this issue or create the new one if the problem persist.