Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update toastandroid.md #1022

Closed
wants to merge 1 commit into from
Closed

update toastandroid.md #1022

wants to merge 1 commit into from

Conversation

ecreeth
Copy link
Contributor

@ecreeth ecreeth commented Jun 13, 2019

This is part of #929

The properties of this component has not changed

was added

@react-native-bot
Copy link

Deploy preview for react-native ready!

Built with commit 5adcdb3

https://deploy-preview-1022--react-native.netlify.com

Changes to docs/ are reflected in the next "master" version.

Thank you for your contributions.

How to ContributeDocumentation Sources

Copy link
Member

@rickhanlonii rickhanlonii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to provide more information for these?

@rachelnabors
Copy link
Contributor

Hey there, @ecreeth! Thanks for your contribution!

I am working with the React Native docs these days and am super looking forward to accepting your pull request! But also, I was wondering if you could provide some more context around what these values do? Like could you expand on TOP, BOTTOM, and CENTER to explain how they change the interaction? That would be so helpful for people new to this space!

If you can update your request, I'm happy to work with you to get it into the site!

Thanks again!

@ecreeth
Copy link
Contributor Author

ecreeth commented Jul 29, 2019

Charmed! but I will have to delete this PR and open another one, since I have removed the fork before and it does not allow me to edit it. 😄 see #1152

@ecreeth ecreeth closed this Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants