Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add upgrade-helper as an upgrading option #1063

Merged
merged 3 commits into from Jul 2, 2019

Conversation

lucasbento
Copy link
Contributor

@lucasbento lucasbento commented Jun 27, 2019

This PR is related to react-native-community/upgrade-helper#38 and adds Upgrade Helper tool as an option to the Upgrading to new React Native versions documentation. It also:

  1. Puts "how to automatic upgrade with CLI without Git" in a troubleshooting section;
  2. Recommends react-native-clean-project as a way to clear project cache after you upgrade but have encountered errors with version mismatch;
  3. Uses yarn instead of npm when asking for installing dependencies.

The second one is done mostly because there was work done by @mikehardy on turning the package into a plugin for the CLI so the user can simply run react-native clean-project.

I'm very much open for feedback on how to improve this.

@lucasbento
Copy link
Contributor Author

cc @kelset, @pvinis & @thymikee.

@react-native-bot
Copy link

react-native-bot commented Jun 27, 2019

Deploy preview for react-native ready!

Built with commit 924b3b4

https://deploy-preview-1063--react-native.netlify.com

Changes to docs/ are reflected in the next "master" version.

Thank you for your contributions.

How to ContributeDocumentation Sources

Copy link
Contributor

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice! I left some suggestions

website/versioned_docs/version-0.5/upgrading.md Outdated Show resolved Hide resolved
website/versioned_docs/version-0.5/upgrading.md Outdated Show resolved Hide resolved
website/versioned_docs/version-0.5/upgrading.md Outdated Show resolved Hide resolved
website/versioned_docs/version-0.5/upgrading.md Outdated Show resolved Hide resolved
website/versioned_docs/version-0.5/upgrading.md Outdated Show resolved Hide resolved
@lucasbento lucasbento mentioned this pull request Jul 1, 2019
@lucasbento
Copy link
Contributor Author

@thymikee: changes done, thanks for the review!

Copy link
Contributor

@cpojer cpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yess

@cpojer cpojer merged commit a3bd7d2 into facebook:master Jul 2, 2019
@lucasbento lucasbento deleted the chore/add-upgrade-helper branch July 22, 2019 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants