Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC]: API Reference for DevSettings.addMenuItem() #1523 #1539

Merged
merged 4 commits into from
Feb 7, 2020

Conversation

mohamedsgap
Copy link
Contributor

Started writing the doc for addMenuItem() as DevSettingsModule.

@react-native-bot
Copy link

react-native-bot commented Jan 3, 2020

Deploy preview for react-native ready!

Built with commit 53cd431

https://deploy-preview-1539--react-native.netlify.com

Changes to docs/ are reflected in the next "master" version.

Thank you for your contributions.

How to ContributeDocumentation Sources

@mohamedsgap
Copy link
Contributor Author

Hey @rickhanlonii just need you to review DevSettings API reference #1539 to see if i wrote it correctly or need some changes!

@mohamedsgap mohamedsgap changed the title [WIP] Doc: DevSettings addMenuItem() [DONE]: Doc for DevSettings addMenuItem() as an API Reference Jan 21, 2020
@mohamedsgap
Copy link
Contributor Author

any updates ? @rickhanlonii

@mohamedsgap mohamedsgap changed the title [DONE]: Doc for DevSettings addMenuItem() as an API Reference [DOC]: API Reference for DevSettings.addMenuItem() Feb 3, 2020
@mohamedsgap mohamedsgap changed the title [DOC]: API Reference for DevSettings.addMenuItem() [DOC]: API Reference for DevSettings.addMenuItem() #1523 Feb 3, 2020
@mohamedsgap
Copy link
Contributor Author

This pull request solved issue ref #1523

Copy link
Member

@rickhanlonii rickhanlonii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can we also move this to the API sidebar after DatePickerAndroid?

docs/devsettings.md Show resolved Hide resolved
```jsx
addMenuItem(title: string, handler: () => )
```
It allows users to add additional dev menu options to their app, so you can use following code to show secret dev screen
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
It allows users to add additional dev menu options to their app, so you can use following code to show secret dev screen
Add a custom menu item to the developer menu:

@mohamedsgap mohamedsgap removed the request for review from cpojer February 5, 2020 13:22
Copy link
Contributor Author

@mohamedsgap mohamedsgap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @rickhanlonii Thanks for reviewing my pull request, I've just made an update according to your suggestion.

@mohamedsgap
Copy link
Contributor Author

Just made an update according to you suggestion, Let's merge the PR :) @rickhanlonii

docs/devsettings.md Outdated Show resolved Hide resolved
@rickhanlonii
Copy link
Member

Just one last fix 👍

Co-Authored-By: Ricky <rickhanlonii@gmail.com>
@mohamedsgap
Copy link
Contributor Author

@rickhanlonii just made an update according to your last suggestion ;)

@rachelnabors rachelnabors merged commit c54779d into facebook:master Feb 7, 2020
espipj pushed a commit to espipj/react-native-website that referenced this pull request Feb 8, 2020
…ebook#1539)

* started doc addMenuItem

* added API reference DevSettings

* Update DevSettings API reference

* Update docs/devsettings.md

Co-Authored-By: Ricky <rickhanlonii@gmail.com>

Co-authored-by: Ricky <rickhanlonii@gmail.com>
kaioduarte pushed a commit to kaioduarte/react-native-website that referenced this pull request Feb 24, 2020
…ebook#1539)

* started doc addMenuItem

* added API reference DevSettings

* Update DevSettings API reference

* Update docs/devsettings.md

Co-Authored-By: Ricky <rickhanlonii@gmail.com>

Co-authored-by: Ricky <rickhanlonii@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants