-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Guide to creating a New Architecture app from template #3056
Merged
cipolleschi
merged 28 commits into
facebook:feat/new-architecture-guide-refactoring
from
lindboe:use-new-template
Apr 20, 2022
Merged
Guide to creating a New Architecture app from template #3056
cipolleschi
merged 28 commits into
facebook:feat/new-architecture-guide-refactoring
from
lindboe:use-new-template
Apr 20, 2022
Commits on Apr 5, 2022
-
This is a first iteration. I want to get feedback on a few aspects, so starting from here as a baseline.
Configuration menu - View commit details
-
Copy full SHA for 06a3766 - Browse repository at this point
Copy the full SHA 06a3766View commit details
Commits on Apr 7, 2022
-
Configuration menu - View commit details
-
Copy full SHA for f6aff0d - Browse repository at this point
Copy the full SHA f6aff0dView commit details -
Set up matching the style of "Getting Started", except I kept the headers inside the tabs for now as it makes for a useful right-hand TOC.
Configuration menu - View commit details
-
Copy full SHA for e7446f2 - Browse repository at this point
Copy the full SHA e7446f2View commit details -
Configuration menu - View commit details
-
Copy full SHA for be2eb18 - Browse repository at this point
Copy the full SHA be2eb18View commit details -
Preliminary section for Hermes
Add section for recommending enabling Hermes. Not sure of contents yet, and still have to test.
Configuration menu - View commit details
-
Copy full SHA for 8754e60 - Browse repository at this point
Copy the full SHA 8754e60View commit details
Commits on Apr 8, 2022
-
Configuration menu - View commit details
-
Copy full SHA for a93abdd - Browse repository at this point
Copy the full SHA a93abddView commit details
Commits on Apr 11, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 5e9a0d9 - Browse repository at this point
Copy the full SHA 5e9a0d9View commit details -
Configuration menu - View commit details
-
Copy full SHA for a1463d8 - Browse repository at this point
Copy the full SHA a1463d8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 77dd04d - Browse repository at this point
Copy the full SHA 77dd04dView commit details -
Favor linking to original setup guide instead of repeating content.
Configuration menu - View commit details
-
Copy full SHA for 7e0ccf0 - Browse repository at this point
Copy the full SHA 7e0ccf0View commit details -
Configuration menu - View commit details
-
Copy full SHA for e98f1b1 - Browse repository at this point
Copy the full SHA e98f1b1View commit details
Commits on Apr 12, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 86a434c - Browse repository at this point
Copy the full SHA 86a434cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3854b96 - Browse repository at this point
Copy the full SHA 3854b96View commit details -
They don't work correctly with the righthand TOC.
Configuration menu - View commit details
-
Copy full SHA for 2105e4f - Browse repository at this point
Copy the full SHA 2105e4fView commit details -
Configuration menu - View commit details
-
Copy full SHA for ea370fb - Browse repository at this point
Copy the full SHA ea370fbView commit details -
Configuration menu - View commit details
-
Copy full SHA for eaa0ee2 - Browse repository at this point
Copy the full SHA eaa0ee2View commit details -
Opt for instructions using XCode
Because `xcodebuild clean` already failed me once when XCode GUI clean worked.
Configuration menu - View commit details
-
Copy full SHA for 7ea7ef0 - Browse repository at this point
Copy the full SHA 7ea7ef0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 02a9b4e - Browse repository at this point
Copy the full SHA 02a9b4eView commit details -
Configuration menu - View commit details
-
Copy full SHA for f845267 - Browse repository at this point
Copy the full SHA f845267View commit details -
Configuration menu - View commit details
-
Copy full SHA for c0a3d43 - Browse repository at this point
Copy the full SHA c0a3d43View commit details -
Configuration menu - View commit details
-
Copy full SHA for d5bc865 - Browse repository at this point
Copy the full SHA d5bc865View commit details -
Configuration menu - View commit details
-
Copy full SHA for eea036b - Browse repository at this point
Copy the full SHA eea036bView commit details -
Configuration menu - View commit details
-
Copy full SHA for f5e1324 - Browse repository at this point
Copy the full SHA f5e1324View commit details -
Also standardize on using yarn scripts from template for commands, it's a little confusing to see the mix of `npx` and `yarn` once we start referring to `yarn pod-install`
Configuration menu - View commit details
-
Copy full SHA for aada4dc - Browse repository at this point
Copy the full SHA aada4dcView commit details -
Configuration menu - View commit details
-
Copy full SHA for df4c17e - Browse repository at this point
Copy the full SHA df4c17eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9e06f9d - Browse repository at this point
Copy the full SHA 9e06f9dView commit details
Commits on Apr 13, 2022
-
Configuration menu - View commit details
-
Copy full SHA for cbb01bc - Browse repository at this point
Copy the full SHA cbb01bcView commit details
Commits on Apr 14, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 1ea529b - Browse repository at this point
Copy the full SHA 1ea529bView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.