Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT][TNA] Fabric Component - Improve Structure and Naming #3154

Merged
merged 1 commit into from Jun 27, 2022
Merged

[FEAT][TNA] Fabric Component - Improve Structure and Naming #3154

merged 1 commit into from Jun 27, 2022

Conversation

cipolleschi
Copy link
Contributor

This PR reviews the structure of the Headings in order to obtain a better TOC on the Right and make sure that we use consistent naming for the Component.

@cipolleschi cipolleschi changed the base branch from main to feat/tna-fabric-comp-add-to-app-android June 7, 2022 13:15
@netlify
Copy link

netlify bot commented Jun 7, 2022

❌ Deploy Preview for react-native failed.

Name Link
🔨 Latest commit 6761d1b
🔍 Latest deploy log https://app.netlify.com/sites/react-native/deploys/629f4f6b4f715b000ab3a857

@cortinico
Copy link
Contributor

Also the deploy failed with a broken link:

3:18:48 PM: [ERROR] Unable to build website for locale en.
3:18:48 PM: [ERROR] Error: Docusaurus found broken links!
3:18:48 PM: 
3:18:48 PM: Please check the pages of your site in the list below, and make sure you don't reference any path that does not exist.
Note: it's possible to ignore broken links with the 'onBrokenLinks' Docusaurus configuration, and let the build pass.
3:18:48 PM: Exhaustive list of all broken links found:
3:18:48 PM: 
3:18:48 PM: - On source page path = /docs/next/the-new-architecture/use-app-template:
3:18:48 PM:    -> linking to ../build-speed.md (resolved as: /docs/next/build-speed.md)

@cipolleschi
Copy link
Contributor Author

Yes, they are broken because I have to rebase the container and all the PR depending on it... 😅
But given that we have a bunch of children PR open, I'll wait until they are merged into the container, otherwise I will have to rebase all of them and it is a waste of time, imho...

@cipolleschi cipolleschi force-pushed the feat/tna-fabric-comp-add-to-app-android branch from d3095fe to 515e0ba Compare June 13, 2022 14:09
@cipolleschi cipolleschi force-pushed the feat/tna-fabric-comp-bells-and-whistles branch from 6761d1b to 6be4b2a Compare June 13, 2022 14:13
@cipolleschi cipolleschi force-pushed the feat/tna-fabric-comp-add-to-app-android branch 4 times, most recently from 85d37cd to b3963d9 Compare June 17, 2022 02:47
@cipolleschi cipolleschi force-pushed the feat/tna-fabric-comp-bells-and-whistles branch 3 times, most recently from 3617896 to cafed77 Compare June 17, 2022 03:35
@cipolleschi cipolleschi force-pushed the feat/tna-fabric-comp-add-to-app-android branch from b3963d9 to 9573c5d Compare June 17, 2022 22:23
@cipolleschi cipolleschi force-pushed the feat/tna-fabric-comp-bells-and-whistles branch from cafed77 to 9573c5d Compare June 17, 2022 22:30
@cipolleschi cipolleschi reopened this Jun 17, 2022
@cipolleschi cipolleschi merged commit 8558f34 into feat/tna-fabric-comp-add-to-app-android Jun 27, 2022
@cipolleschi cipolleschi deleted the feat/tna-fabric-comp-bells-and-whistles branch June 27, 2022 15:12
cipolleschi pushed a commit that referenced this pull request Jun 27, 2022
[FEAT][TNA] Fabric Component - Add Component to App (Android) (#3153)
9384150 
* feat: Add fabric component to app - Android

* feat: improve structure and consistency (#3154)
cipolleschi pushed a commit that referenced this pull request Jun 27, 2022
[FEAT][TNA] Fabric Component - Add Native Code (Android) (#3152)
27f0506 
* feat: add native code for android

* [FEAT][TNA] Fabric Component - Add Component to App (Android) (#3153)

* feat: Add fabric component to app - Android

* feat: improve structure and consistency (#3154)
cipolleschi pushed a commit that referenced this pull request Jun 27, 2022
[FEAT][TNA] Fabric Component - Add Component to App (iOS) (#3149)
e567fd8 
* feat: add fabric component to app - ios

* [FEAT][TNA] Fabric Component - Add Native Code (Android) (#3152)

* feat: add native code for android

* [FEAT][TNA] Fabric Component - Add Component to App (Android) (#3153)

* feat: Add fabric component to app - Android

* feat: improve structure and consistency (#3154)
cipolleschi pushed a commit that referenced this pull request Jun 27, 2022
[FEAT][TNA] Fabric Component - Add Native Code (iOS) (#3148)
955956b 
* feat: Add native code for iOS

* [FEAT][TNA] Fabric Component - Add Component to App (iOS) (#3149)

* feat: add fabric component to app - ios

* [FEAT][TNA] Fabric Component - Add Native Code (Android) (#3152)

* feat: add native code for android

* [FEAT][TNA] Fabric Component - Add Component to App (Android) (#3153)

* feat: Add fabric component to app - Android

* feat: improve structure and consistency (#3154)
cipolleschi pushed a commit that referenced this pull request Jun 27, 2022
[FEAT][TNA] Fabric Component - Add Configuration Files (#3136)
1d7ea8f 
* feat: add section on configuration

* [FEAT][TNA] Fabric Component - Add Native Code (iOS) (#3148)

* feat: Add native code for iOS

* [FEAT][TNA] Fabric Component - Add Component to App (iOS) (#3149)

* feat: add fabric component to app - ios

* [FEAT][TNA] Fabric Component - Add Native Code (Android) (#3152)

* feat: add native code for android

* [FEAT][TNA] Fabric Component - Add Component to App (Android) (#3153)

* feat: Add fabric component to app - Android

* feat: improve structure and consistency (#3154)
cipolleschi pushed a commit that referenced this pull request Jun 27, 2022
[Feat][TNA] Fabric Component - Create Folder Structure and Define JS …
eed9eb9 
…Specs (#3133)

* [Feat] Add JavaScript for Fabric Components

* [FEAT][TNA] Fabric Component - Add Configuration Files (#3136)

* feat: add section on configuration

* [FEAT][TNA] Fabric Component - Add Native Code (iOS) (#3148)

* feat: Add native code for iOS

* [FEAT][TNA] Fabric Component - Add Component to App (iOS) (#3149)

* feat: add fabric component to app - ios

* [FEAT][TNA] Fabric Component - Add Native Code (Android) (#3152)

* feat: add native code for android

* [FEAT][TNA] Fabric Component - Add Component to App (Android) (#3153)

* feat: Add fabric component to app - Android

* feat: improve structure and consistency (#3154)
@cipolleschi cipolleschi restored the feat/tna-fabric-comp-bells-and-whistles branch June 27, 2022 15:23
@cipolleschi cipolleschi deleted the feat/tna-fabric-comp-bells-and-whistles branch November 25, 2022 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cortinico cortinico cortinico left review comments

@lindboe lindboe lindboe left review comments

Assignees
No one assigned
Labels
CLA Signed p: Facebook Partner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cipolleschi @cortinico @lindboe @facebook-github-bot