Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chores(releases): rename script and add info note #3815

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

kelset
Copy link
Contributor

@kelset kelset commented Aug 9, 2023

This a follow up PR to update the docs to reflect a recent change in the release crew flow facebook/react-native#38666

This is currently in the process of getting aligned & backported across the release support window:

This PR needs to be merged AFTER all those PRs are merged.

@netlify
Copy link

netlify bot commented Aug 9, 2023

Deploy Preview for react-native ready!

Name Link
🔨 Latest commit 01688e6
🔍 Latest deploy log https://app.netlify.com/sites/react-native/deploys/64d3a2628f60c700085b321e
😎 Deploy Preview https://deploy-preview-3815--react-native.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

# This will walk you through what version you are releasing
./scripts/bump-oss-version.js --to-version 0.69.0-rc.0 --token <YOUR_CIRCLE_CI_TOKEN>
yarn trigger-react-native-release --to-version 0.69.0-rc.0 --token <YOUR_CIRCLE_CI_TOKEN>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
yarn trigger-react-native-release --to-version 0.69.0-rc.0 --token <YOUR_CIRCLE_CI_TOKEN>
yarn trigger-react-native-release --to-version 0.y.0-rc.0 --token <YOUR_CIRCLE_CI_TOKEN>

We use this format elsewhere, so we might as well can align here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the entire page is using 0.69 as the example version, so I'd rather keep it consistent across the page. Someone as a follow up PR (maybe in 6 months or so, to connect to your other comment) could do a pass on all the release pages and update them to change both the example code and remove "old versions" references. In quite a few pages we have things like "before 0.71" or even "before 0.68".
So maybe by the time 0.74 comes around (this Q4 or early next year) that would be a good time to give an overall pass to the whole section to remove old references.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine for now, but since 0.69 is out of support already, maybe we can remove this note in not-so-distant future?

@kelset
Copy link
Contributor Author

kelset commented Aug 21, 2023

@Simek this PR is ready to be merged - all the PRs that were pending are merged so now we need to merge this so that the docs are aligned.

It's already approved by Meta (Alex) and current release crew (Marek) so all that's left is to get it in. I'm not sure if there's something I can do about the CircleCI error, it's totally unrelated. Do you want me to try and rebase the PR to see if that fixes it?

@Simek Simek merged commit 3043261 into facebook:main Aug 21, 2023
4 checks passed
@kelset kelset deleted the kelset/change-bump-oss-name branch August 21, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants