Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recover debugging native code section #3895

Merged
merged 2 commits into from
Oct 25, 2023
Merged

Recover debugging native code section #3895

merged 2 commits into from
Oct 25, 2023

Conversation

tuliocll
Copy link
Contributor

Hi.
I checked the current native debugging section in docs and realized that my previous PR that adds more instructions was deleted, I think this is because the file name was changed or something like that.

Current doc:
current debugging doc

0.71 doc:
old debugging doc

@netlify
Copy link

netlify bot commented Oct 24, 2023

Deploy Preview for react-native ready!

Name Link
🔨 Latest commit 4a81555
🔍 Latest deploy log https://app.netlify.com/sites/react-native/deploys/6538f1c28b3a5d00081cde5c
😎 Deploy Preview https://deploy-preview-3895--react-native.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Simek
Copy link
Collaborator

Simek commented Oct 24, 2023

Looks like this part has been removed in #3693 refactor, let's make sure it was not done on purpose, before reverting it.

@Simek Simek requested a review from huntie October 24, 2023 12:18
Copy link
Member

@huntie huntie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup looks like I mistakenly removed this, apologies. Thanks!

@Simek
Copy link
Collaborator

Simek commented Oct 25, 2023

@tuliocll Can you backport the changes also to 0.72 versioned docs, so those section will be visible in the default version seen by user too?

@tuliocll
Copy link
Contributor Author

tuliocll commented Oct 25, 2023

@tuliocll Can you backport the changes also to 0.72 versioned docs, so those section will be visible in the default version seen by user too?

Done!

@huntie huntie merged commit 36caace into facebook:main Oct 25, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants