Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decrease margin between sidebar and content. #83

Merged
merged 1 commit into from Dec 20, 2017

Conversation

Tonours
Copy link
Contributor

@Tonours Tonours commented Dec 20, 2017

Due to anchor link fix, margin between sidebar and content container has been increase, from 60px to 100px.

In order to fix this issue, docsNavContainer now have a width of 240px and mainContainer has a margin-left of 20px on screen greater than 1024px.

Before
capture d ecran 2017-12-19 a 21 41 37

After
capture d ecran 2017-12-19 a 21 37 46

#71 and #79

Due to anchor link fix, margin between sidebar
and content container has been increase,
from 60px to 100px.

In order to fix this issue, docsNavContainer now have
a width of 240px and mainContainer has a margin-left
of 20px on screen greater than 1024px.
@Tonours
Copy link
Contributor Author

Tonours commented Dec 20, 2017

Please @charpeni can you take a look at this fix ? By advance, thank you :-)

Copy link
Contributor

@charpeni charpeni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you for your contribution!

@Tonours
Copy link
Contributor Author

Tonours commented Dec 20, 2017

@charpeni De rien ! Thanks to you to have catch this error :-)

@hramos hramos merged commit 9aa0d97 into facebook:master Dec 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants