Fix 'Release Notes' link on versions page #86
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a problem with the 'Release Notes' link on the versions page.
There was an unwrapped ternary expression:
Which evaluates like:
Making the href attribute always
-rc.0
.The fix just wraps the ternary statement in brackets, for the intended functionality:
Which, obviously, evaluates like:
I also fixed unique 'key' prop warnings in the same file, by moving the key to the
VersionItem
component itself rather than thetr
element inside theVersionItem
component.Also some Prettier fixes that were nothing to do with me, but couldn't commit without them. 馃槢