Skip to content

Commit

Permalink
Modernize docs: remove 'use strict' from docs -- es6 has 'use strict'…
Browse files Browse the repository at this point in the history
… by default

Summary:
Removed <b>'use strict'</b> from docs since ES6 Modules already use <b>'use strict'</b>  by default.

https://stackoverflow.com/questions/31685262/not-recommended-to-use-use-strict-in-es6

> 10.2.1 Strict Mode Code

> An ECMAScript Script syntactic unit may be processed using either unrestricted or strict mode syntax and semantics. Code is interpreted as strict mode code in the following situations:

> Global code is strict mode code if it begins with a Directive Prologue that contains a Use Strict Directive (see 14.1.1).
Module code is always strict mode code.
All parts of a ClassDeclaration or a ClassExpression are strict mode code.
Eval code is strict mode code if it begins with a Directive Prologue that contains a Use Strict Directive or if the call to eval is a direct eval (see 12.3.4.1) that is contained in strict mode code.
Function code is strict mode code if the associated FunctionDeclaration, FunctionExpression, GeneratorDeclaration, GeneratorExpression, MethodDefinition, or ArrowFunction is contained in strict mode code or if the code that produces the value of the function’s [[ECMAScriptCode]] internal slot begins with a Directive Prologue that contains a Use Strict Directive.
Function code that is supplied as the arguments to the built-in Function and Generator constructors is strict mode code if the last argument is a String that when processed is a FunctionBody that begins with a Directive Prologue that contains a Use Strict Directive.

Spec: http://www.ecma-international.org/ecma-262/6.0/#sec-strict-mode-code
Closes #16163

Differential Revision: D5968746

Pulled By: hramos

fbshipit-source-id: 308f49184b1565311d5fd71786639eaee13be60a
  • Loading branch information
indreklasn authored and facebook-github-bot committed Oct 4, 2017
1 parent 992ade1 commit e1fb6ff
Show file tree
Hide file tree
Showing 7 changed files with 4 additions and 7 deletions.
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Expand Up @@ -180,7 +180,7 @@ However, there are still some styles that the linter cannot pick up.
#### JavaScript #### JavaScript


* Use semicolons; * Use semicolons;
* `'use strict';` * ES6 standards
* Prefer `'` over `"` * Prefer `'` over `"`
* Do not use the optional parameters of `setTimeout` and `setInterval` * Do not use the optional parameters of `setTimeout` and `setInterval`
* 80 character line length * 80 character line length
Expand Down
1 change: 0 additions & 1 deletion docs/CommunicationAndroid.md
Expand Up @@ -46,7 +46,6 @@ public class MainActivity extends ReactActivity {
``` ```


``` ```
'use strict';
import React from 'react'; import React from 'react';
import { import {
Expand Down
1 change: 0 additions & 1 deletion docs/CommunicationIOS.md
Expand Up @@ -39,7 +39,6 @@ RCTRootView *rootView = [[RCTRootView alloc] initWithBridge:bridge
``` ```


``` ```
'use strict';
import React from 'react'; import React from 'react';
import { import {
Expand Down
2 changes: 1 addition & 1 deletion docs/Contributing.md
Expand Up @@ -187,7 +187,7 @@ However, there are still some styles that the linter cannot pick up.
#### JavaScript #### JavaScript


* Use semicolons; * Use semicolons;
* `'use strict';` * ES6 standards
* Prefer `'` over `"` * Prefer `'` over `"`
* Do not use the optional parameters of `setTimeout` and `setInterval` * Do not use the optional parameters of `setTimeout` and `setInterval`
* 80 character line length * 80 character line length
Expand Down
2 changes: 2 additions & 0 deletions docs/CustomWebViewIOS.md
Expand Up @@ -151,6 +151,7 @@ To use your custom web view, you'll need to create a class for it. Your class mu
To get your native component, you must use `requireNativeComponent`: the same as for regular custom components. However, you must pass in an extra third argument, `WebView.extraNativeComponentConfig`. This third argument contains prop types that are only required for native code. To get your native component, you must use `requireNativeComponent`: the same as for regular custom components. However, you must pass in an extra third argument, `WebView.extraNativeComponentConfig`. This third argument contains prop types that are only required for native code.


```js ```js

import React, { Component, PropTypes } from 'react'; import React, { Component, PropTypes } from 'react';
import { WebView, requireNativeComponent, NativeModules } from 'react-native'; import { WebView, requireNativeComponent, NativeModules } from 'react-native';
const { CustomWebViewManager } = NativeModules; const { CustomWebViewManager } = NativeModules;
Expand All @@ -176,6 +177,7 @@ const RCTCustomWebView = requireNativeComponent(
CustomWebView, CustomWebView,
WebView.extraNativeComponentConfig WebView.extraNativeComponentConfig
); );

``` ```


If you want to add custom props to your native component, you can use `nativeConfig.props` on the web view. For iOS, you should also set the `nativeConfig.viewManager` prop with your custom WebView ViewManager as in the example above. If you want to add custom props to your native component, you can use `nativeConfig.props` on the web view. For iOS, you should also set the `nativeConfig.viewManager` prop with your custom WebView ViewManager as in the example above.
Expand Down
2 changes: 0 additions & 2 deletions docs/IntegrationWithExistingApps.md
Expand Up @@ -305,7 +305,6 @@ First, create an empty `index.js` file in the root of your React Native project.
In your `index.js`, create your component. In our sample here, we will add simple `<Text>` component within a styled `<View>` In your `index.js`, create your component. In our sample here, we will add simple `<Text>` component within a styled `<View>`


```javascript ```javascript
'use strict';


import React from 'react'; import React from 'react';
import { import {
Expand Down Expand Up @@ -600,7 +599,6 @@ First, create an empty `index.js` file in the root of your React Native project.
In your `index.js`, create your component. In our sample here, we will add simple `<Text>` component within a styled `<View>`: In your `index.js`, create your component. In our sample here, we will add simple `<Text>` component within a styled `<View>`:


```javascript ```javascript
'use strict';


import React from 'react'; import React from 'react';
import { import {
Expand Down
1 change: 0 additions & 1 deletion docs/NativeModulesAndroid.md
Expand Up @@ -144,7 +144,6 @@ protected List<ReactPackage> getPackages() {
To make it simpler to access your new functionality from JavaScript, it is common to wrap the native module in a JavaScript module. This is not necessary but saves the consumers of your library the need to pull it off of `NativeModules` each time. This JavaScript file also becomes a good location for you to add any JavaScript side functionality. To make it simpler to access your new functionality from JavaScript, it is common to wrap the native module in a JavaScript module. This is not necessary but saves the consumers of your library the need to pull it off of `NativeModules` each time. This JavaScript file also becomes a good location for you to add any JavaScript side functionality.


```js ```js
'use strict';
/** /**
* This exposes the native ToastExample module as a JS module. This has a * This exposes the native ToastExample module as a JS module. This has a
* function 'show' which takes the following parameters: * function 'show' which takes the following parameters:
Expand Down

0 comments on commit e1fb6ff

Please sign in to comment.