-
Notifications
You must be signed in to change notification settings - Fork 24.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trying to add 24 hour format to react-native DatePickerIOS #12405
Comments
The UIDatePicker displays time based on the user's locale. It doesn't seem like you can override that behavior in terms of UI. |
You can if you initialise it for a different locale, that's what I tested it and it does work. |
Hi there! This issue is being closed because it has been inactive for a while. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. Either way, we're automatically closing issues after a period of inactivity. Please do not take it personally! If you think this issue should definitely remain open, please let us know. The following information is helpful when it comes to determining if the issue should be re-opened:
If you would like to work on a patch to fix the issue, contributions are very welcome! Read through the contribution guide, and feel free to hop into #react-native if you need help planning your contribution. |
This is a long requested feature, but no one seems to be doing anything about it.
I'm trying to add a boolean value to our DateTimePickerIOS so that the js part of it looks like this:
Then I modified
React > Views > RCTDateTimePickerManager.m
. Specifically I added this code:That solution is based on this SO answer.
I've tried to do this, but with no luck at all.. Even-though this code compiles with no errors, I can't seem to do what I want.
On the other hand, I know that solution works, because when I modify this code on the same react-native file:
I do get a 24hour time picker, but I want to be able to do this from js.
Any ideas would be appreciated.
Also if someone from the fb team pointed me to the right direction I could open a pull request.
Thanks.
The text was updated successfully, but these errors were encountered: