-
Notifications
You must be signed in to change notification settings - Fork 24.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modal won't open on iOS when __DEV__ is true/Debugger is turned on #12747
Comments
I can confirm this |
Duplicate of #12515 |
Just met the error today, it brokes our dev app. I hope a fix will be published soon (as version 0.42.1) 😞 |
For anyone looking into it here is what Jodi was referencing about AppContainer: https://github.com/facebook/react-native/blob/master/Libraries/Modal/Modal.js#L159-L162 |
I've narrowed it down further to this line in YellowBox: https://github.com/facebook/react-native/blob/master/Libraries/ReactNative/YellowBox.js#L377 When you remove I'm still debugging to see what this is supposed to be. List styles are: list: {
backgroundColor: 'transparent',
position: 'absolute',
left: 0,
right: 0,
bottom: 0,
elevation: Number.MAX_VALUE
}, So I'm guessing this somehow is blocking the modal. |
Ok this is actually fixed but I don't think has been put in a release yet? that |
@JustinDFuller Sorry, I should've updated with that information. But yeah, I've been using that fix since the PR was first posted about a week ago. It definitely works for me. |
@JodiWarren Cool you might want to close this issue then |
Description
After updating to 0.42, none of our click-triggered Modals are opening when Remote JS Debugging is set to true. This seems to be related to https://github.com/facebook/react-native/blob/master/Libraries/Modal/Modal.js#L159. If we override it to
innerChildren = this.props.children
, it works perfectly.Sadly there are no errors in the DevTools, even with Pause on Caught Exception on. It just fails silently.
A quick gif illustration of the problem follows:
Reproduction
I've created a new project with
react-native init
, and just added in the Modal example from the docs: https://github.com/JodiWarren/BrokenModalIf you clone that down, run
react-native run-ios
and then turn on Remote JS Debugging, you should find that the modal no longer works when activated.Solution
I don't fully understand what
<AppContainer>
is doing in this situation, so I don't feel confident in proposing a fix. I'm open to suggestions though, and will happily submit a PR if I find anything robust.Additional Information
The text was updated successfully, but these errors were encountered: