-
Notifications
You must be signed in to change notification settings - Fork 24.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No Carthage support #13835
Comments
@ahmadmuhsink Hey! Did you end up finding a way to add the fbsdk to your project without using cocoapods? I'm in the same boat. We're using carthage and don't want to use cocoapods for various reasons. However I've looked around and it looks like Facebook will not be adding Carthage support to the FBSDK. However they are adding the support for there SWIFT fbsdk package (which I don't think we can use with the react-native-fbsdk package). |
@jamesone If you really need this carthage support you can add framework scheme by yourself, but that requires fork and will be hard to manage version. |
Yeah I figured 😄 How do you setup the fbsdk? Do you use cocoapods? I'm interested to know because we really need to setup the fbsdk but don't want to use cocoapods...so I'm exploring all options at the moment 👍 |
@ahmadmuhsink Do you use the swift SDK with react-native? |
@jamesone Nope, I didnt use cocoapods, fbsdk, and swift sdk. I only use react-native, and I use it as |
Carthage is gaining some serious space in the dependency management of iOS apps. This should definitely move up to a higher priority. |
Agreed. Carthage support would be nice. |
We are considering react native but, we use carthage extensively. When will this be available? |
What is better about Carthage compare to CocoaPods with React Native? :D |
I don't think it's necessarily an issue of "better", as much as people not wanting to implement Yet Another Dependency Manager in their project if they don't have to. CocoaPods and Carthage take very different approaches to dependency management. As such, many teams standardize on one or the other. If RN supported Carthage, people who have adopted Carthage as their dependency manager would not have to implement another one in the form of CocoaPods, and incur the additional maintenance overhead of another third party tool in their projects. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. If you think this issue should definitely remain open, please let us know why. Thank you for your contributions. |
Is there any update on Carthage support? If not, @ahmadmuhsink can you keep this issue open to track Carthage support of RN? Closed issue gets less attention. Thanks! |
I'd also like to see this issue remain open to track Carthage support. |
alright. reopen the issue. |
Another vote for this (and to keep it open). |
+1, keep it open, I also would prefer to use it with Carthage. |
Did anyone find a solution for this, we're also planning to try react-native but we are using Carthage. |
We're currently taking a hybrid Pod/Carthage approach, but are only using Pod for React Native so would be great to get everything over to Carthage |
why is this closed again ? Would also love to see this happen. |
Is that a subtle way to announce that there will not be Carthage support? |
Given all the requests for this, coupled with the sheer resources FB has, I find it silly this has not been implemented. Even worse this has not received any feedback from the dev team one way or the other and is continually closed. In my opinion very unprofessional. |
Description
I use carthage as dependency manager. (CocoaPod alternative)
I add facebook/react-native as one of the dependency.
I run carthage update (similar with pod install). Its failed to build react-native because its not compatible.
Reproduction Steps and Sample Code
use carthage as your dependency manager https://github.com/Carthage/Carthage
add this repo as dependency.
build
Additional Information
The text was updated successfully, but these errors were encountered: