Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Carthage support #13835

Closed
ahmadmuhsink opened this issue May 8, 2017 · 21 comments
Closed

No Carthage support #13835

ahmadmuhsink opened this issue May 8, 2017 · 21 comments
Labels
Stale There has been a lack of activity on this issue and it may be closed soon.

Comments

@ahmadmuhsink
Copy link

ahmadmuhsink commented May 8, 2017

Description

I use carthage as dependency manager. (CocoaPod alternative)
I add facebook/react-native as one of the dependency.

I run carthage update (similar with pod install). Its failed to build react-native because its not compatible.

Skipped building react-native due to the error:
Dependency "react-native" has no shared framework schemes for any of the platforms: iOS

Reproduction Steps and Sample Code

use carthage as your dependency manager https://github.com/Carthage/Carthage

add this repo as dependency.
build

Additional Information

  • React Native version: 0.44
  • Platform: iOS
  • Development Operating System: MacOS
  • Dev tools: Xcode
@jamesone
Copy link

jamesone commented Jun 6, 2017

@ahmadmuhsink Hey! Did you end up finding a way to add the fbsdk to your project without using cocoapods?

I'm in the same boat. We're using carthage and don't want to use cocoapods for various reasons.

However I've looked around and it looks like Facebook will not be adding Carthage support to the FBSDK. However they are adding the support for there SWIFT fbsdk package (which I don't think we can use with the react-native-fbsdk package).

@ahmadmuhsink
Copy link
Author

ahmadmuhsink commented Jun 6, 2017

@jamesone
Hey! I use different approach for this. I need this carthage support because I want to have RN native module as library. I use git submodules for now.

If you really need this carthage support you can add framework scheme by yourself, but that requires fork and will be hard to manage version.

@jamesone
Copy link

jamesone commented Jun 6, 2017

Yeah I figured 😄 How do you setup the fbsdk? Do you use cocoapods? I'm interested to know because we really need to setup the fbsdk but don't want to use cocoapods...so I'm exploring all options at the moment 👍
@ahmadmuhsink

@jamesone
Copy link

jamesone commented Jun 6, 2017

@ahmadmuhsink Do you use the swift SDK with react-native?

@ahmadmuhsink
Copy link
Author

@jamesone Nope, I didnt use cocoapods, fbsdk, and swift sdk.

I only use react-native, and I use it as submodules for my native modules bridges. https://github.com/blog/2104-working-with-submodules

@lswith
Copy link

lswith commented Jul 21, 2017

Carthage is gaining some serious space in the dependency management of iOS apps. This should definitely move up to a higher priority.

@bootstraponline
Copy link

Agreed. Carthage support would be nice.

@blackholesoftware
Copy link

We are considering react native but, we use carthage extensively. When will this be available?

@henrikra
Copy link

What is better about Carthage compare to CocoaPods with React Native? :D

@khawkins
Copy link

I don't think it's necessarily an issue of "better", as much as people not wanting to implement Yet Another Dependency Manager in their project if they don't have to. CocoaPods and Carthage take very different approaches to dependency management. As such, many teams standardize on one or the other.

If RN supported Carthage, people who have adopted Carthage as their dependency manager would not have to implement another one in the form of CocoaPods, and incur the additional maintenance overhead of another third party tool in their projects.

@stale
Copy link

stale bot commented Dec 24, 2017

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. If you think this issue should definitely remain open, please let us know why. Thank you for your contributions.

@stale stale bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label Dec 24, 2017
@dhei
Copy link

dhei commented Jan 5, 2018

Is there any update on Carthage support?

If not, @ahmadmuhsink can you keep this issue open to track Carthage support of RN? Closed issue gets less attention.

Thanks!

@bootstraponline
Copy link

I'd also like to see this issue remain open to track Carthage support.

@ahmadmuhsink
Copy link
Author

alright. reopen the issue.

@ahmadmuhsink ahmadmuhsink reopened this Jan 9, 2018
@stale stale bot closed this as completed Jan 16, 2018
@gianpaj
Copy link

gianpaj commented Mar 15, 2018

Another vote for this (and to keep it open).
I've encountered many issues with install and linking third-party modules with and without cocoapods.
I'm sure Carthage won't fix every issue, but I feel like there has to be a better way to install native modules.

@michallaskowski
Copy link

+1, keep it open, I also would prefer to use it with Carthage.

@KarlHarnois
Copy link

Did anyone find a solution for this, we're also planning to try react-native but we are using Carthage.

@jamesrford7
Copy link

We're currently taking a hybrid Pod/Carthage approach, but are only using Pod for React Native so would be great to get everything over to Carthage

@dehlen
Copy link
Contributor

dehlen commented Jul 6, 2018

why is this closed again ? Would also love to see this happen.

@LeeroyDing
Copy link

Is that a subtle way to announce that there will not be Carthage support?

@doonware
Copy link

doonware commented Oct 2, 2018

Given all the requests for this, coupled with the sheer resources FB has, I find it silly this has not been implemented.

Even worse this has not received any feedback from the dev team one way or the other and is continually closed. In my opinion very unprofessional.

@facebook facebook locked as resolved and limited conversation to collaborators Jan 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Stale There has been a lack of activity on this issue and it may be closed soon.
Projects
None yet
Development

No branches or pull requests