Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated regression testing #14864

Closed
pokey opened this issue Jul 6, 2017 · 6 comments
Closed

Automated regression testing #14864

pokey opened this issue Jul 6, 2017 · 6 comments
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@pokey
Copy link

pokey commented Jul 6, 2017

I've taken a couple swings at react native over the past couple years, and every time I do, I run into some recent issue that results in react native not working out-of-the-box when following the getting-started guide. I don't remember which issue it was the past couple times I tried, but this time around I've hit both #14838 and #14767. Are there not regression tests, and if there are, is there no automated check to ensure that they pass before merging to master / cutting a release?

Beyond the obvious confusion / frustration this can cause a newbie, I imagine that it probably leads to a reluctance on the part of existing users of the framework to upgrade. For my part, I'll be hesitant to upgrade RN for fear something will break.

I realize this is pre-1.0 software, but it's been pre-1.0 for more than 2 years, and is widely used. Maybe it's time to put in place a set of regression tests that are automatically enforced prior to merge / release?

@otoinsa
Copy link

otoinsa commented Jul 6, 2017

I've also noticed this in the past year I've been working with RN; so I've grown very cautious of the platform.

I would be really cool if it worked as it should, but I guess we're back to the respective IDE's and programming languages for each of the major mobile platforms.

@pvinis
Copy link
Contributor

pvinis commented Jul 12, 2017

@otoinsa kind of bitter response.
@pokey i agree, there should be some testing for regressions. these bugs in new releases are a pain to fix, and mess up the ci/cd that we have set up.

@pokey
Copy link
Author

pokey commented Jul 12, 2017

@pvinis Ok, so there is ci/cd that enforces various tests before release / merge to master, then? So the issue is that the tests that are already in place and automatically enforced just need to be more extensive?

@pvinis
Copy link
Contributor

pvinis commented Jul 12, 2017

no no. I mean the bugs mess with my ci/cd I have for my project in react native. when I need to do manual steps like the config.h problem, my server cannot build automatically and I need to intervene. I have no idea what kind of testing they have from Facebook for react native, but I agree we should have some that catch these upgrade problems.

@hramos
Copy link
Contributor

hramos commented Sep 21, 2017

Hi there! This issue is being closed because it has been inactive for a while. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. Either way, we're automatically closing issues after a period of inactivity. Please do not take it personally!

If you think this issue should definitely remain open, please let us know. The following information is helpful when it comes to determining if the issue should be re-opened:

  • Does the issue still reproduce on the latest release candidate? Post a comment with the version you tested.
  • If so, is there any information missing from the bug report? Post a comment with all the information required by the issue template.
  • Is there a pull request that addresses this issue? Post a comment with the PR number so we can follow up.

If you would like to work on a patch to fix the issue, contributions are very welcome! Read through the contribution guide, and feel free to hop into #react-native if you need help planning your contribution.

@hramos hramos added the Icebox label Sep 21, 2017
@hramos hramos closed this as completed Sep 21, 2017
@pvinis
Copy link
Contributor

pvinis commented Sep 25, 2017

i would say this issue is good to stay around, because otherwise it will just get forgotten, and more people will complain for the same problems.

@facebook facebook locked as resolved and limited conversation to collaborators Sep 21, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Sep 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

5 participants