Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RCTImageFromLocalAssetURL is loading image from web #16799

Closed
douglasjunior opened this issue Nov 12, 2017 · 2 comments
Closed

RCTImageFromLocalAssetURL is loading image from web #16799

douglasjunior opened this issue Nov 12, 2017 · 2 comments
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@douglasjunior
Copy link

douglasjunior commented Nov 12, 2017

Is this a bug report?

I dont know if this is a Bug.

The docs says that RCTImageFromLocalAssetURL loads only local images.

// Returns an UIImage for a local image asset. Returns nil if the URL
// does not correspond to a local asset.

But in recent version of RN, it is also loading image from web (https).

My question is, this is intentional? Because this breaks my previous logic.

Have you read the Contributing Guidelines?

Yes.

Environment

Environment:
OS: macOS Sierra 10.12.6
Node: 6.11.3
Yarn: 1.3.2
npm: 5.5.1
Watchman: 4.9.0
Xcode: Xcode 9.1 Build version 9B55
Android Studio: EAP AI-171.4429293 AI-171.4429293

Packages: (wanted => installed)
react: 16.0.0 => 16.0.0
react-native: 0.50.3 => 0.50.3

Steps to Reproduce

Call RCTImageFromLocalAssetURL with a web image URI.

Expected Behavior

Return nil if a non local image is provided.

Actual Behavior

This is loading image from the web.

@react-native-bot
Copy link
Collaborator

@facebook-github-bot no-template

@douglasjunior
Copy link
Author

douglasjunior commented Nov 12, 2017

@react-native-bot @facebook-github-bot now have template ¬¬

#16800

@facebook facebook locked as resolved and limited conversation to collaborators Nov 12, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Nov 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

2 participants