Prefix ANDROID_LONG_TIMER_MESSAGE with "(ADVICE)" so it doesn't generate non-actionable support requests.

[mikelehen]

Can we please please please change the warning text here to be prefixed with "(ADVICE)" so it’s no longer as disruptive?

react-native/Libraries/Core/Timers/JSTimers.js

Line 54 in 3fa6482

const ANDROID_LONG_TIMER_MESSAGE =

Context:
The Firebase JavaScript SDK uses setTimeout / setInterval for a variety of tasks that need to be scheduled. For example, refreshing auth tokens, making reconnect attempts after a backoff delay, etc. This is done in the standard JavaScript way by using setInterval() or setTimeout().

React Native supports timers of any length, but currently displays a non-actionable but disruptive yellow warning if you schedule a timer for > 60 seconds.

react-native/Libraries/Core/Timers/JSTimers.js

Line 52 in 3fa6482

const MAX_TIMER_DURATION_MS = 60 * 1000;

The warning references #12981 which has received a very large amount of comments, upvotes, etc., but it does not actually provide any solution. As far as I can tell, the underlying issue is a React Native one (in how it implements setTimeout / setInterval on Android) and there's nothing developers can do.

Firebase has received multiple support requests and github issues (e.g. firebase/firebase-js-sdk#97, firebase/firebase-js-sdk#283) and the comments regarding Firebase on #12981 have gathered over 100 upvotes.

We (Firebase) have no way to fix this other than reduce our timeouts which if anything will make things worse (we would need to set multiple short timeouts to get to the desired longer timeout).

From my reading of the code, warnings prefixed with "(ADVICE)" do not result in the disruptive yellow box:

react-native/Libraries/ReactNative/YellowBox.js

Line 126 in eae4fe8

if (warning.startsWith('(ADVICE)')) {

So can we please please please change the warning text here to be prefixed with "(ADVICE)" so it’s no longer as disruptive?

react-native/Libraries/Core/Timers/JSTimers.js

Line 54 in 3fa6482

const ANDROID_LONG_TIMER_MESSAGE =

[react-native-bot]

@facebook-github-bot no-template

[facebook-github-bot]

Hey @mikelehen, thanks for posting this! It looks like your issue is missing some required information. Can you please add all the details specified in the Issue Template? This is necessary for people to be able to understand and reproduce your issue. I am going to close this, but please feel free to open a new issue with the additional information provided. Thanks!

_{How to Contribute • What to Expect from Maintainers}

[mikelehen]

Reopened as #17083