Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The --device option fails on command line in v53.0 #17921

Closed
berkcoker opened this issue Feb 9, 2018 · 4 comments
Closed

The --device option fails on command line in v53.0 #17921

berkcoker opened this issue Feb 9, 2018 · 4 comments
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@berkcoker
Copy link

berkcoker commented Feb 9, 2018

Is this a bug report?

Yes

Have you read the Contributing Guidelines?

Yes

Environment

Environment:
OS: macOS High Sierra 10.13.3
Node: 8.9.0
Yarn: Not Found
npm: 5.6.0
Watchman: 4.9.0
Xcode: Xcode 9.2 Build version 9C40b
Android Studio: Not Found

Packages: (wanted => installed)
react: ^16.2.0 => 16.2.0
react-native: ^0.53.0 => 0.53.0

Steps to Reproduce

The following commit that came with the new release (v53.0) causes problems when the --device option is specified. The port is set to undefined for the Metro bundler.

react-native run-ios now supports the --port argument for metro (33d710e)

@react-native-bot
Copy link
Collaborator

@facebook-github-bot no-template

@facebook-github-bot
Copy link
Contributor

Something went wrong executing that command, @hramos could you take a look?

@hramos
Copy link
Contributor

hramos commented Feb 9, 2018

Hey, thanks for reporting this issue!

It looks like your description is missing some necessary information, or the list of reproduction steps is not complete. Can you please add all the details specified in the template? This is necessary for people to be able to understand and reproduce the issue being reported.

I am going to close this, but feel free to open a new issue that meets the requirements set forth in the template. Thanks!

@hramos hramos closed this as completed Feb 9, 2018
@gulci
Copy link

gulci commented Feb 14, 2018

I'm having this issue as well. I've reopened it for him here: #17973

@facebook facebook locked as resolved and limited conversation to collaborators Feb 9, 2019
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Feb 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

5 participants