Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RN 0.54.4, 0.56.0-rc.4] RNFetchBlob requires main queue setup since it overrides constantsToExport but doesn't implement requiresMainQueueSetup #19960

Closed
fungilation opened this issue Jun 29, 2018 · 3 comments
Labels
Good first issue Interested in collaborating? Take a stab at fixing one of these issues. Help Wanted :octocat: Issues ideal for external contributors. 🌐Networking Related to a networking API. Platform: iOS iOS applications. Resolution: Locked This issue was locked by the bot.

Comments

@fungilation
Copy link

fungilation commented Jun 29, 2018

Environment

  React Native Environment Info:
    System:
      OS: macOS High Sierra 10.13.5
      CPU: x64 Intel(R) Core(TM) i7-3520M CPU @ 2.90GHz
      Memory: 36.54 MB / 8.00 GB
      Shell: 3.2.57 - /bin/bash
    Binaries:
      Node: 10.5.0 - /usr/local/bin/node
      Yarn: 1.7.0 - /usr/local/bin/yarn
      npm: 6.1.0 - /usr/local/bin/npm
      Watchman: 4.9.0 - /usr/local/bin/watchman
    SDKs:
      iOS SDK:
        Platforms: iOS 11.4, macOS 10.13, tvOS 11.4, watchOS 4.3
      Android SDK:
        Build Tools: 23.0.1, 23.0.3, 25.0.1, 25.0.3, 26.0.1, 27.0.3
        API Levels: 23, 25, 26, 27
    IDEs:
      Android Studio: 3.1 AI-173.4720617
      Xcode: 9.4.1/9F2000 - /usr/bin/xcodebuild
    npmPackages:
      react: 16.4.1 => 16.4.1 
      react-native: 0.56.0-rc.4 => 0.56.0-rc.4 
    npmGlobalPackages:
      eslint-plugin-react-native: 1.2.0
      react-native-cli: 0.2.0
      react-native-git-upgrade: 0.2.7

Description

Reproducible Demo

$ react-native run-ios

yellowbox log:
Module RNFetchBlob requires main queue setup since it overrides constantsToExport but doesn't implement requiresMainQueueSetup. In a future release React Native will default to initializing all native modules on a background thread unless explicitly opted-out of.

screenshot 2018-06-28 22 10 27

Same kind of issue as #17504, needing similar kind of fix: #17679

@react-native-bot react-native-bot added the 🌐Networking Related to a networking API. label Jun 29, 2018
@hramos hramos added Platform: iOS iOS applications. Help Wanted :octocat: Issues ideal for external contributors. labels Jun 29, 2018
@hramos
Copy link
Contributor

hramos commented Jun 29, 2018

Thanks for the issue! Someone want to send a quick PR to add this?

@hramos hramos added the Good first issue Interested in collaborating? Take a stab at fixing one of these issues. label Jun 29, 2018
@patrickkempff
Copy link
Contributor

@hramos I am not sure if RNFetchBlob is even part of RN

@fungilation
Copy link
Author

Oops, you're right. Closed

@facebook facebook locked as resolved and limited conversation to collaborators Jun 29, 2019
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jun 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Good first issue Interested in collaborating? Take a stab at fixing one of these issues. Help Wanted :octocat: Issues ideal for external contributors. 🌐Networking Related to a networking API. Platform: iOS iOS applications. Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

4 participants