Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Fix eslint code analysis bot #20822

Closed
wants to merge 1 commit into from
Closed

Conversation

hramos
Copy link
Contributor

@hramos hramos commented Aug 23, 2018

The eslint bot has not been working since the migration to Circle 2.0.

Test Plan: Ran on CI

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 23, 2018
@react-native-bot react-native-bot added Core Team Missing Test Plan This PR appears to be missing a test plan. Missing Changelog This PR appears to be missing a changelog, or they are incorrectly formatted. labels Aug 24, 2018
@hramos hramos changed the title [CI] [WIP] Update eslint code analysis bot [CI] Update eslint code analysis bot Aug 24, 2018
@hramos hramos changed the title [CI] Update eslint code analysis bot [CI] Fix eslint code analysis bot Aug 24, 2018
@facebook-github-bot facebook-github-bot added the Import Started This pull request has been imported. This does not imply the PR has been approved. label Aug 24, 2018
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot react-native-bot added ✅Test Plan and removed Missing Test Plan This PR appears to be missing a test plan. labels Aug 24, 2018
@react-native-bot
Copy link
Collaborator

@hramos merged commit 1fe7b40 into facebook:master.


Once this commit is added to a release, you will see the corresponding version tag below the description at 1fe7b40. If the commit has a single master tag, it is not yet part of a release.

@facebook facebook locked as resolved and limited conversation to collaborators Aug 24, 2018
@react-native-bot react-native-bot added the Merged This PR has been merged. label Aug 24, 2018
empyrical pushed a commit to empyrical/react-native that referenced this pull request Aug 24, 2018
Summary:
The eslint bot has not been working since the migration to Circle 2.0.
Pull Request resolved: facebook#20822

Differential Revision: D9492680

Pulled By: hramos

fbshipit-source-id: 7f2f9ac125b6cab1750902c485a6d27d6c3cf302
@hramos hramos removed Import Started This pull request has been imported. This does not imply the PR has been approved. labels Feb 6, 2019
t-nanava pushed a commit to microsoft/react-native-macos that referenced this pull request Jun 17, 2019
Summary:
The eslint bot has not been working since the migration to Circle 2.0.
Pull Request resolved: facebook#20822

Differential Revision: D9492680

Pulled By: hramos

fbshipit-source-id: 7f2f9ac125b6cab1750902c485a6d27d6c3cf302
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Missing Changelog This PR appears to be missing a changelog, or they are incorrectly formatted.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants