Add iOS 12 textContentType options #21079
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
eslint-bot
reviewed
Sep 12, 2018
| @@ -155,6 +155,8 @@ type IOSProps = $ReadOnly<{| | |||
| | 'telephoneNumber' | |||
| | 'username' | |||
| | 'password' | |||
| | 'newPassword' | |||
| | 'oneTimeCode' | |||
There was a problem hiding this comment.
no-trailing-spaces: Trailing spaces not allowed.
ultramiraculous
force-pushed
the
patch-1
branch
from
0f5eeb8
to
250da76
Compare
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Sep 13, 2018
There was a problem hiding this comment.
TheSavior is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@ultramiraculous merged commit 644fc57 into Once this commit is added to a release, you will see the corresponding version tag below the description at 644fc57. If the commit has a single |
gengjiawen
pushed a commit
to gengjiawen/react-native
that referenced
this pull request
Sep 14, 2018
Summary: Adding the new `textContentType` options from iOS 12. `newPassword` helps the OS know to put a password field into the keychain, and `oneTimeCode` hints that the field will take input from an SMS one time code. Pull Request resolved: facebook#21079 Differential Revision: D9813328 Pulled By: TheSavior fbshipit-source-id: d2c04b41121b32f185af38ea4c642924e261a043
kelset
pushed a commit
that referenced
this pull request
Nov 26, 2018
Summary: Adding the new `textContentType` options from iOS 12. `newPassword` helps the OS know to put a password field into the keychain, and `oneTimeCode` hints that the field will take input from an SMS one time code. Pull Request resolved: #21079 Differential Revision: D9813328 Pulled By: TheSavior fbshipit-source-id: d2c04b41121b32f185af38ea4c642924e261a043
hramos
removed
Import Started
t-nanava
pushed a commit
to microsoft/react-native-macos
that referenced
this pull request
Jun 17, 2019
Summary: Adding the new `textContentType` options from iOS 12. `newPassword` helps the OS know to put a password field into the keychain, and `oneTimeCode` hints that the field will take input from an SMS one time code. Pull Request resolved: facebook#21079 Differential Revision: D9813328 Pulled By: TheSavior fbshipit-source-id: d2c04b41121b32f185af38ea4c642924e261a043
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the new
textContentTypeoptions from iOS 12.newPasswordhelps the OS know to put a password field into the keychain, andoneTimeCodehints that the field will take input from an SMS one time code.Test Plan:
The flow-typing for the new types should work like the others. Functionally there shouldn't be much to break because the API on the iOS side is taking a string and doesn't break if you give it new input.
Release Notes:
[IOS] [ENHANCEMENT] [ReactNative] - Add iOS 12
textContentTypeoptions forTextInput