Adding 404.js to catch 404s on website #2145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me: http://stackoverflow.com/questions/5411538/redirect-from-an-html-page |
facebook-github-bot
added
the
CLA Signed
|
|
||
| var React = require('React'); | ||
|
|
||
| var four_oh_four = React.createClass({ |
There was a problem hiding this comment.
In JS the convention is fourOhFour.
mkonicek
added a commit
that referenced
this pull request
Jul 28, 2015
Adding 404.js to catch 404s on website
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
404s on the website currently redirect to code.facebook.com because we have no root 404.html - this adds one that will be generated by the website script, that redirects all 404s to the root docs page.