[ANDROID][BUGFIX][TextInput] - Fixed line not breaking when multiline set to true and keyboard type set to numeric (or other numeric type)

[Muritavo]

Native Android sets the EditText widget to multiline only if the InputType flags are set to Text (or its variants like textEmailAddress) and Multiline, which causes the React Native TextInput to not break the line when set to multiline={true} and keyboardType={'numeric'} as it only have the flags Multiline and Number set.

This fix forces the widget to enable multiline, by calling setSingleLine(false) everytime a state change needs to be commited and the multiline prop is set to true.

Test Plan:

This bug only occurs on Android devices

1. Create a TextInput component with multiline set to true and keyboardType set to 'numeric' or 'phone-pad' or any numeric type.

<TextInput
   keyboardType={"numeric"}
   numberOfLines={6}
   multiline={true}/>

2. Input some text until it reaches the end of the component

3. See as you keep input more data, the line doesn't break

The test plan can be reproduced HERE

Release Notes:

[ANDROID] [BUGFIX] [TextInput] - Fixed line not breaking when multiline set to true and keyboard type set to numeric (or other numeric type)

[facebook-github-bot]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[matthargett]

Can you add an e2e test for this?

[Muritavo]

Sure, this week I'm a little busy with the exams coming, so I'll only be able to look into this after wednesday

[RSNara]

@Muritavo, thanks for the PR!

One question: Are you sure that this is sufficient to fix the bug? If you replace numberOfLines with a really long placeholder, we still can't get multiline numeric <TextInput/>s. 🤔

<TextInput
  multiline={true}
  keyboardType="numeric"
  style={styles.input}
  placeholder="some really really really really really really long text"
/>

Do you think that's a different problem? I'm asking because maybe there's a better solution that fixes both cases.

[mmamaniwolox]

It would be awesome to have this working, great job @Muritavo . I hope this is merged soon :P Need it so bad haha

[facebook-github-bot]

@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[react-native-bot]

Murilo Araujo merged commit 28f1648 into facebook:master.