Make jest react-native preset to use typescript files #22217
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Generated by 🚫 dangerJS |
dulmandakh
reviewed
Nov 8, 2018
jest/hasteImpl.js
Outdated
| // strip .js/.js.flow suffix | ||
| [/^(.*)\.js(\.flow)?$/, '$1'], | ||
| // strip .js/.ts/.tsx/.js.flow suffix | ||
| [/^(.*)\.(js|ts|tsx)(\.flow)?$/, '$1'], |
There was a problem hiding this comment.
this regex will match ts.flow and tsx.flow
|
cc @rafeca in case there are additional files we need to be aware of. |
cpojer
reviewed
Dec 7, 2018
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Dec 10, 2018
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
hramos
removed
Import Started
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Metro and react-native now have first-class support to Typescript with Babel 7, but react-native Jest preset needs specific settings to work with .ts and .tsx files.
This PR updates react-native Jest preset to use Typescript out of the box.
Test Plan:
There is a test to the hasteImpl file.
Changelog:
[GENERAL] [CHANGE] - Add Typescript to Jest react-native preset.