Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text on Android has shadow by default #22367

Closed
3 tasks done
lukasgeiter opened this issue Nov 21, 2018 · 4 comments
Closed
3 tasks done

Text on Android has shadow by default #22367

lukasgeiter opened this issue Nov 21, 2018 · 4 comments
Labels
Component: Text Platform: Android Android applications. Ran Commands One of our bots successfully processed a command. Resolution: Locked This issue was locked by the bot.

Comments

@lukasgeiter
Copy link

lukasgeiter commented Nov 21, 2018

Environment

[skip envinfo]

Description

On Android, all text has a faint shadow. This is barely noticeable in most cases but becomes visible with light colored text. As an extreme example, this is "Test" in white font on white background:

image

I would expect the text to be completely invisible but instead there is a faint shadow.

Reproducible Demo

No demo

Cause

This is a regression which has been introduced by b7ba225 and is present since version 0.57.2.
The problem is that the default value for textShadowRadius is 1. I'm not sure why that is, but I think it probably should be 0 which would solve this issue.

Workaround

The workaround is to manually set the radius to 0:

<Text style={{ textShadowRadius: 0 }}>
    Test
</Text>
@react-native-bot
Copy link
Collaborator

We are automatically closing this issue because it does not appear to follow any of the provided issue templates.

Please make use of the bug report template to let us know about a reproducible bug or regression in the core React Native library.

If you'd like to propose a change or discuss a feature request, there is a repository dedicated to Discussions and Proposals you may use for this purpose.

@react-native-bot react-native-bot added Ran Commands One of our bots successfully processed a command. 📋No Template labels Nov 21, 2018
@lukasgeiter
Copy link
Author

@react-native-bot Issue updated, please reopen.

@sterlingwes
Copy link
Contributor

Seems related to #21507

@lukasgeiter
Copy link
Author

@sterlingwes It definitely is. I've retested with v0.57.8 and it's fixed, so this issue can stay closed 🙂

@facebook facebook locked as resolved and limited conversation to collaborators Nov 21, 2019
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Nov 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Component: Text Platform: Android Android applications. Ran Commands One of our bots successfully processed a command. Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

3 participants