Make RNTester build and pass again #22468
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
TheSavior
commented
Dec 1, 2018
| @@ -8,7 +8,7 @@ | |||
| /* eslint-env jasmine */ | |||
There was a problem hiding this comment.
I moved this file because jest requires all files in the __tests__ directory to have tests. I believe this is getting fixed soon but this makes things pass until then.
Generated by 🚫 dangerJS |
There was a problem hiding this comment.
@TheSavior has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@TheSavior merged commit 3749da1 into |
rozele
pushed a commit
to microsoft/react-native-windows
that referenced
this pull request
Jul 18, 2019
Summary: Detox was failing because of build errors due to the new xcode10 build system. These errors were fixed by RSNara in facebook/react-native@b7349f9 but this callsite was missed. Pull Request resolved: facebook/react-native#22468 Reviewed By: RSNara Differential Revision: D13287386 Pulled By: TheSavior fbshipit-source-id: 8a2df9801c69d851eabe7074ffc12b29c03a636a
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detox was failing because of build errors due to the new xcode10 build system. These errors were fixed by @RSNara in b7349f9 but this callsite was missed.
Test Plan:
I ran
yarn build-ios-e2e && yarn test-ios-e2e.Before this change I got build errors like:
Changelog:
[General] [Fixed] - RNTester runs and passes again in CI