Use main.jsbundle in iOS template for production build #22531
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make it semaless, reduce complexity for newcoming Based on https://facebook.github.io/react-native/docs/running-on-device#3-configure-app-to-use-static-bundle
facebook-github-bot
added
the
CLA Signed
radeno
changed the title
radeno
changed the title
react-native-bot
added
Tech: Bundler 📦
|
The CLI has been moved to https://github.com/react-native-community/react-native-cli. The |
|
@hramos thanks for keeping an eye on the CLI-related PRs! We have agreed that the default template located in I guess this can change in the future, but for now, that's where this PR should go. CC: @cpojer |
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Dec 7, 2018
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
kelset
pushed a commit
that referenced
this pull request
Dec 12, 2018
Summary: Default HelloWorld template for iOS doesn't make production main.jsbundle. This is little bit confusing in compare with Android building app when everything works one first run. Make it seamless, reduce confuse. Based on docs https://facebook.github.io/react-native/docs/running-on-device#3-configure-app-to-use-static-bundle Fixes #22335 Fixes #18562 Pull Request resolved: #22531 Differential Revision: D13372773 Pulled By: cpojer fbshipit-source-id: 888c675b7d11b1a323445e092ec9ff83924c42f4
hramos
removed
Import Started
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default HelloWorld template for iOS doesn't make production main.jsbundle. This is little bit confusing in compare with Android building app when everything works one first run.
Make it seamless, reduce confuse.
Based on docs https://facebook.github.io/react-native/docs/running-on-device#3-configure-app-to-use-static-bundle
Fixes #22335
Fixes #18562
Test Plan:
CI green
Changelog:
[iOS] [Changed] - Use main.jsbundle in template for production build