Make TextInput event prop types less strict #22673
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
cc @TheSavior |
TheSavior
approved these changes
Dec 16, 2018
|
I can merge this from my work computer on Monday. Remind me if this doesn't get merged then. |
react-native-bot
added
🔶Components
Component: Text
Component: TextInput
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Dec 17, 2018
There was a problem hiding this comment.
@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@janicduplessis merged commit c3caca9 into |
hramos
removed
Import Started
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to what was done here #22376
This allows using things like async functions with text input event props.
Test Plan:
Run flow
Changelog:
[General] [Fixed] - Make TextInput event prop types less strict