Remove ActivityIndicator from ScrollView snapshot tests #22729
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Dec 20, 2018
There was a problem hiding this comment.
@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
hramos
added a commit
to hramos/react-native
that referenced
this pull request
Dec 20, 2018
hramos
added a commit
to hramos/react-native
that referenced
this pull request
Dec 20, 2018
grabbou
pushed a commit
that referenced
this pull request
Dec 24, 2018
Summary: `ActivityIndicator` was not consistent when running snapshot tests so I removed it. From diff:  Changelog: ---------- [iOS] [FIXED] - Fixed ScrollViewExample snapshot tests Pull Request resolved: #22729 Differential Revision: D13528756 Pulled By: hramos fbshipit-source-id: 747d91ad6a8fb8f0aa8022496bd8855a90710142
hramos
removed
Import Started
t-nanava
pushed a commit
to microsoft/react-native-macos
that referenced
this pull request
Jun 17, 2019
Summary: `ActivityIndicator` was not consistent when running snapshot tests so I removed it. From diff:  Changelog: ---------- [iOS] [FIXED] - Fixed ScrollViewExample snapshot tests Pull Request resolved: facebook#22729 Differential Revision: D13528756 Pulled By: hramos fbshipit-source-id: 747d91ad6a8fb8f0aa8022496bd8855a90710142
rozele
pushed a commit
to microsoft/react-native-windows
that referenced
this pull request
Jul 18, 2019
Summary: `ActivityIndicator` was not consistent when running snapshot tests so I removed it. From diff:  Changelog: ---------- [iOS] [FIXED] - Fixed ScrollViewExample snapshot tests Pull Request resolved: facebook/react-native#22729 Differential Revision: D13528756 Pulled By: hramos fbshipit-source-id: 747d91ad6a8fb8f0aa8022496bd8855a90710142
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ActivityIndicatorwas not consistent when running snapshot tests so I removed it.From diff:
Changelog:
[iOS] [FIXED] - Fixed ScrollViewExample snapshot tests
Test Plan:
yarnat the repository root.RNTester/RNTester.xcodeprojon Xcode 10.1.0.RNTesterSnapshotTests).Fixes #22696