Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Standalone for NativeComponents] AndroidDropdownPicker and AndroidDialogPicker #22999

Conversation

Naturalclar
Copy link
Contributor

@Naturalclar Naturalclar commented Jan 15, 2019

Changelog:

[Android] [Changed] - As mentioned in #22990, I have moved native components required by PickerAndroid.android.js into separate files and added Flow Typing.

Test Plan:

  • npm test
  • npm run flow
  • npm run flow-check-android
  • npm run lint Libraries/Components/Picker

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 15, 2019
Copy link

@analysis-bot analysis-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code analysis results:

  • eslint found some issues.
  • flow found some issues.

accessibilityLabel?: ?string,
|}>;

type DialogPickerNativeType = Class<NativeComponent<NativeProps>>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prettier/prettier: Insert ;


module.exports = ((requireNativeComponent(
'AndroidDialogPicker',
): any): DialogPickerNativeType);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unclear type. Using any, Object, or Function types is not safe! (unclear-type)


module.exports = ((requireNativeComponent(
'AndroidDropdownPicker',
): any): DropdownPickerNativeType);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unclear type. Using any, Object, or Function types is not safe! (unclear-type)

@pull-bot
Copy link

Warnings
⚠️

📋 Changelog - This PR appears to be missing Changelog.

Generated by 🚫 dangerJS

Copy link

@analysis-bot analysis-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code analysis results:

  • flow found some issues.


module.exports = ((requireNativeComponent(
'AndroidDialogPicker',
): any): DialogPickerNativeType);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unclear type. Using any, Object, or Function types is not safe! (unclear-type)


module.exports = ((requireNativeComponent(
'AndroidDropdownPicker',
): any): DropdownPickerNativeType);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unclear type. Using any, Object, or Function types is not safe! (unclear-type)

@Naturalclar Naturalclar changed the title [Standalone for NativeComponents] AndroidDropdownPicker [Standalone for NativeComponents] AndroidDropdownPicker and AndroidDialogPicker Jan 16, 2019
@facebook-github-bot facebook-github-bot added the Import Started This pull request has been imported. This does not imply the PR has been approved. label Jan 16, 2019
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TheSavior is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@TheSavior TheSavior self-assigned this Jan 16, 2019
@react-native-bot
Copy link
Collaborator

@Naturalclar merged commit 462cb10 into facebook:master.

@facebook facebook locked as resolved and limited conversation to collaborators Jan 16, 2019
@react-native-bot react-native-bot added the Merged This PR has been merged. label Jan 16, 2019
@TheSavior
Copy link
Member

Thanks for contributing!

@Naturalclar Naturalclar deleted the issue22990_AndroidDropdownPicker branch January 17, 2019 01:22
@hramos hramos removed Import Started This pull request has been imported. This does not imply the PR has been approved. labels Feb 6, 2019
matt-oakes pushed a commit to matt-oakes/react-native that referenced this pull request Feb 7, 2019
Summary:
Changelog:
----------

[Android] [Changed] - As mentioned in facebook#22990, I have moved native components required by PickerAndroid.android.js into separate files and added Flow Typing.
Pull Request resolved: facebook#22999

Differential Revision: D13697130

Pulled By: TheSavior

fbshipit-source-id: 42da73d82cca45fefa066871eed5a637811643c8
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Platform: Android Android applications.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants