[Standalone for NativeComponents] RCTSegmentedControl #23000
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
analysis-bot
suggested changes
Jan 15, 2019
Libraries/Components/SegmentedControlIOS/RCTSegmentedControlNativeComponent.js
Outdated
Show resolved
Hide resolved
Libraries/Components/SegmentedControlIOS/RCTSegmentedControlNativeComponent.js
Outdated
Show resolved
Hide resolved
Generated by 🚫 dangerJS |
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Jan 16, 2019
There was a problem hiding this comment.
@TheSavior is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
Thanks for contributing! |
hramos
removed
Import Started
matt-oakes
pushed a commit
to matt-oakes/react-native
that referenced
this pull request
Feb 7, 2019
Summary: Changelog: ---------- [iOS] [Changed] - follow facebook#22990, move the call to requireNativeComponent from `SegmentedControlIOS.ios.js` to `RCTSegmentedControlNativeComponent.js` Pull Request resolved: facebook#23000 Differential Revision: D13697168 Pulled By: TheSavior fbshipit-source-id: 83a66279d2fcd5a29d2ebc9cf5b5273947d96281
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog:
[iOS] [Changed] - follow #22990, move the call to requireNativeComponent from
SegmentedControlIOS.ios.jstoRCTSegmentedControlNativeComponent.jsTest Plan: