Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] [Changed] - Create individual RCTSnapshotNativeComponent JS fil… #23012

Closed
wants to merge 1 commit into from
Closed

[iOS] [Changed] - Create individual RCTSnapshotNativeComponent JS fil… #23012

wants to merge 1 commit into from

Conversation

arcodergh
Copy link
Contributor

@arcodergh arcodergh commented Jan 15, 2019 •
edited

Part of #22990

Changelog:

[iOS] [Changed] - Create individual RCTSnapshotNativeComponent JS file from SnapshotViewIOS

Test Plan:

  • npm run lint
  • npm run flow-check-ios
  • npm run flow
  • npm run test

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Tests This PR adds or edits a test case. labels Jan 15, 2019
@facebook-github-bot facebook-github-bot added the Import Started This pull request has been imported. This does not imply the PR has been approved. label Jan 15, 2019
facebook-github-bot
facebook-github-bot approved these changes Jan 15, 2019
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PeteTheHeat is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

PeteTheHeat
PeteTheHeat approved these changes Jan 15, 2019
View reviewed changes
Copy link
Contributor

@PeteTheHeat PeteTheHeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@react-native-bot
Copy link
Collaborator

@arcodergh merged commit c93f683 into facebook:master.

@facebook facebook locked as resolved and limited conversation to collaborators Jan 16, 2019
@react-native-bot react-native-bot added the Merged This PR has been merged. label Jan 16, 2019
@hramos hramos removed Import Started This pull request has been imported. This does not imply the PR has been approved. labels Feb 6, 2019
matt-oakes pushed a commit to matt-oakes/react-native that referenced this pull request Feb 7, 2019
@arcodergh @facebook-github-bot
- Create individual RCTSnapshotNativeComponent JS fil… (facebook#23012)
fbc88e5 
Summary:
Part of facebook#22990

Changelog:
----------
[iOS] [Changed] - Create individual ```RCTSnapshotNativeComponent``` JS file from ```SnapshotViewIOS```
Pull Request resolved: facebook#23012

Differential Revision: D13683566

Pulled By: PeteTheHeat

fbshipit-source-id: d7a030dd59e9c5dd88f7ddd92734486063c5f450
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@PeteTheHeat PeteTheHeat PeteTheHeat approved these changes

@facebook-github-bot facebook-github-bot facebook-github-bot approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Platform: iOS iOS applications. Tests This PR adds or edits a test case.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@arcodergh @react-native-bot @PeteTheHeat @facebook-github-bot @hramos