[Standalone for NativeComponents] RCTProgressView #23077
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
Hi @TheSavior, I was wondering if there's anything out of the ordinary regarding the failing tests and missing labels, which weren't added to this PR? |
There was a problem hiding this comment.
@cpojer has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
added
the
Import Started
cpojer
approved these changes
Jan 22, 2019
|
Thank you for this PR! :) |
|
@RCiesielczuk merged commit f2ab0eb into |
hramos
removed
Import Started
matt-oakes
pushed a commit
to matt-oakes/react-native
that referenced
this pull request
Feb 7, 2019
Summary: Created a standalone JS file for the `RCTProgressView` native component. This PR is part of facebook#22990. Changelog: ---------- [iOS] [Changed] - Created a standalone JS file for the `RCTProgressView` native component Pull Request resolved: facebook#23077 Differential Revision: D13760036 Pulled By: cpojer fbshipit-source-id: 0f449528b28fde089d9c6b0eb9b752dee3a85af6
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a standalone JS file for the
RCTProgressViewnative component.This PR is part of #22990.
Changelog:
[iOS] [Changed] - Created a standalone JS file for the
RCTProgressViewnative componentTest Plan: