bug in RCTLocationObserver.m #23145
Labels
Ran Commands
One of our bots successfully processed a command.
Resolution: Locked
This issue was locked by the bot.
Comments
|
We are automatically closing this issue because it does not appear to follow any of the provided issue templates. Please make use of the bug report template to let us know about a reproducible bug or regression in the core React Native library. If you'd like to propose a change or discuss a feature request, there is a repository dedicated to Discussions and Proposals you may use for this purpose. |
react-native-bot
added
Ran Commands
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Hi,
related to #17145
The part
if (ABS(_locationManager.desiredAccuracy - RCT_DEFAULT_LOCATION_ACCURACY) > 0.000001) {on line ~ 360 of RCTLocationObserver.m always resets the location accuracy to the default value.It should rather check if _observingLocation is true and use _observerOptions.accuracy instead, like this:
if (_observingLocation && ABS(_locationManager.desiredAccuracy - _observerOptions.accuracy) > 0.000001) { _locationManager.desiredAccuracy = _observerOptions.accuracy; } if (!_observingLocation && ABS(_locationManager.desiredAccuracy - RCT_DEFAULT_LOCATION_ACCURACY) > 0.000001) { _locationManager.desiredAccuracy = RCT_DEFAULT_LOCATION_ACCURACY; }Cheers and thanks for the great work!
The text was updated successfully, but these errors were encountered: