add back buildToolsVersion to build.gradle #23316
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
hramos
approved these changes
Feb 6, 2019
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Feb 6, 2019
There was a problem hiding this comment.
@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@dulmandakh merged commit cf52ab5 into |
hramos
removed
Import Started
matt-oakes
pushed a commit
to matt-oakes/react-native
that referenced
this pull request
Feb 7, 2019
Summary: add back buildToolsVersion to build.gradle, because many third-party modules depend on it. The lack of this info causing issues in 0.58. [Android] [Changed] - add back buildToolsVersion to template Pull Request resolved: facebook#23316 Differential Revision: D13974264 Pulled By: hramos fbshipit-source-id: 058fc5617196d6481d1b69d2420c8b2be9cf4f81
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
add back buildToolsVersion to build.gradle, because many third-party modules depend on it. The lack of this info causing issues in 0.58.
Changelog
[Android] [Changed] - add back buildToolsVersion to template
Test Plan
CI is green, and everything should work as normal.