@Nonnull annotation for ReactPackage #23415
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
dulmandakh
changed the title
hey99xx
approved these changes
Feb 13, 2019
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Feb 13, 2019
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
can't wait to have Kotlin code in RN 👍 |
gengjiawen
approved these changes
Feb 13, 2019
|
@dulmandakh merged commit 84f40da into |
grabbou
pushed a commit
that referenced
this pull request
Feb 13, 2019
Summary: Here are some leftovers from nullable annotations for native modules, discovered while developing native module in Kotlin. This will help improve Kotlin developer experience [Android] [Changed] - Add Nonnull annotations to ReactPackage Pull Request resolved: #23415 Differential Revision: D14064607 Pulled By: cpojer fbshipit-source-id: af2ce1fc1911ee03c54b20a4fc3a6d1aba9267da
hramos
removed
Import Started
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Here are some leftovers from nullable annotations for native modules, discovered while developing native module in Kotlin. This will help improve Kotlin developer experience
Changelog
[Android] [Changed] - Add @nonnull annotations to ReactPackage
Test Plan
CI is green