[iOS] Fixed ScrollView adjust inset behavior #23555
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
react-native-bot
added
Component: ScrollView
Platform: iOS
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Feb 21, 2019
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@zhongwuzw merged commit 2ea4bcd into |
mbardauskas
pushed a commit
to mbardauskas/react-native
that referenced
this pull request
Feb 21, 2019
Summary: Fixes facebook#23500 , if user set prop `contentInsetAdjustmentBehavior="automatic"` of ScrollView, it not works when initial on the screen. We fixes it by filter valid offset, if offset is valid, just return. [iOS] [Fixed] - Fixed ScrollView adjust inset behavior Pull Request resolved: facebook#23555 Differential Revision: D14161593 Pulled By: cpojer fbshipit-source-id: 01434e55106ffde7f8e39f66dd5b0f02df9b38b1
hramos
removed
Import Started
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #23500 , if user set prop
contentInsetAdjustmentBehavior="automatic"of ScrollView, it not works when initial on the screen. We fixes it by filter valid offset, if offset is valid, just return.Changelog
[iOS] [Fixed] - Fixed ScrollView adjust inset behavior
Test Plan
Fixes #23500 .