Eliminate eslint npm version mismatch warnings and bump some to latest #23969
Conversation
…st for some of these eslint packages. Some we can't easily update to latest (eslint-plugin-prettier) because the rule format has changed a bit. Happy to do that in this PR if folks agree. eslint-config-fbjs itself needs to be updated and republished to eliminate the last few warnings.
facebook-github-bot
added
CLA Signed
|
…pecified some of the package bumps I did in the base directory.
| "eslint-plugin-eslint-comments": "^3.1.1", | ||
| "eslint-plugin-flowtype": "2.50.3", | ||
| "eslint-plugin-jest": "22.4.1", | ||
| "eslint-plugin-jsx-a11y": "6.2.1", |
There was a problem hiding this comment.
Looks like this plugin is targeting web: https://github.com/evcohen/eslint-plugin-jsx-a11y#supported-rules
It's also not enabled in the config's plugin list. I think that can be removed.
For RN there's https://github.com/FormidableLabs/eslint-plugin-react-native-a11y but it stopped receiving support shortly after release and iirc it still lacks some accessibility features introduced in 0.57
There was a problem hiding this comment.
Whoops, scratch my last comment. I thought it's about the community plugin. eslint-config-fbjs requires the eslint-plugin-jsx-a11y
|
May take a little while to get this landed as the eslint version is tied to the internal version at fb. |
…orkaround a random eslintrc in there that was getting picked up.
Took it back down to eslint ^5.1.0, since that's what metro repo is at. I submitted another PR to fbjs to align these versions and eliminate more of the warnings as well. |
…t/react-native into eliminate-eslint-npm-warnings
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary
I was annoyed by warnings from yarn/npm about eslint peer dependencies not being met, so I dived in to try and get rid of some of them. Sometimes it meant bumping a plugin, but then that plugin needed a newer babel-eslint, so it was a dance.
Some we can't easily update to latest (eslint-plugin-prettier) because the rule format has changed a bit. Happy to do that in this PR if folks think its a good idea. eslint-config-fbjs itself needs to be updated and republished to eliminate the last few warnings.
There are a few new warnings (the repo wasn't linting cleanly for me from the start). I can fix those in this PR, or a separate one, based on people's preferences.
Changelog
[internal] [chore] - Eliminate some peer dependency warnings and bump some eslint packages to latest.
Test Plan
eslint ., verified no major new warnings detected and that seemingly none of the new warnings were false positives.